Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(frontend): make "Search" box the first filter for charts and datasets #25129

Merged
merged 2 commits into from
Aug 30, 2023
Merged

refactor(frontend): make "Search" box the first filter for charts and datasets #25129

merged 2 commits into from
Aug 30, 2023

Conversation

sfirke
Copy link
Member

@sfirke sfirke commented Aug 30, 2023

SUMMARY

Continues #19721, making that same change for Charts and Datasets for consistency.

Fixes #25128.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE

image
image

AFTER
image
image

TESTING INSTRUCTIONS

Compare before & after.

ADDITIONAL INFORMATION

  • Has associated issue: fixes "Search" box is last in search boxes for charts, datasets #25128
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@sfirke
Copy link
Member Author

sfirke commented Aug 30, 2023

cc @michael-s-molina in case you think this would be suitable to cherrypick for 3.0.0rc4

michael-s-molina
michael-s-molina approved these changes Aug 30, 2023
View reviewed changes
Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michael-s-molina michael-s-molina added the v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch label Aug 30, 2023
@sfirke sfirke merged commit eeecd59 into apache:master Aug 30, 2023
27 checks passed
@sfirke sfirke deleted the reorder_search_boxes branch August 30, 2023 21:34
michael-s-molina pushed a commit that referenced this pull request Aug 31, 2023
@sfirke @michael-s-molina
refactor(frontend): make "Search" box the first filter for charts and…
46e6d32 
… datasets (#25129)

(cherry picked from commit eeecd59)
darwinsubramaniam pushed a commit to darwinsubramaniam/superset that referenced this pull request Sep 7, 2023
@sfirke @darwinsubramaniam
refactor(frontend): make "Search" box the first filter for charts and…
859dd91 
… datasets (apache#25129)
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@sfirke
refactor(frontend): make "Search" box the first filter for charts and…
8b7f443 
… datasets (apache#25129)
@mistercrunch mistercrunch added 🍒 3.0.0 🍒 3.0.1 🍒 3.0.2 🍒 3.0.3 🍒 3.0.4 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-s-molina michael-s-molina michael-s-molina approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch 🍒 3.0.0 🍒 3.0.1 🍒 3.0.2 🍒 3.0.3 🍒 3.0.4 🚢 3.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Search" box is last in search boxes for charts, datasets
3 participants
@sfirke @michael-s-molina @mistercrunch