fix: Chart series limit doesn't work for some databases #25150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Please review @villebro |
villebro
approved these changes
Aug 31, 2023
|
@KSPT-taylorjohn there's a lint issue: diff --git a/superset/models/helpers.py b/superset/models/helpers.py
index 810de46372..c31caa857e 100644
--- a/superset/models/helpers.py
+++ b/superset/models/helpers.py
@@ -1470,7 +1470,7 @@ class ExploreMixin: # pylint: disable=too-many-public-methods
db_engine_spec.make_label_compatible(column)
for column in utils.get_column_names(
columns=series_columns or [],
- )
+ )
]
# deprecated, to be removed in 2.0
if is_timeseries and timeseries_limit: |
Databases that mutate labels that weren't correctly getting the series limit subquery created.
KSPT-taylorjohn
force-pushed
the
fix_series_limit
branch
from
e26a702
to
62dfee6
Compare
|
@villebro Sorry I have fixed that. |
villebro
added
v3.0
|
@eschutho @michael-s-molina this PR would be great to get into the next patch release of 3.0 and 2.1 (if we're still doing one more for 2.1) |
|
Thanks! I just tagged it for 2.1.2 as well. |
|
FYI @genzgd if someone complains about series limits not working in Superset using Clickhouse Connect |
I'll cherry-pick it for 3.0.0 given that we're still working on RC4. |
michael-s-molina
pushed a commit
that referenced
this pull request
Sep 1, 2023
(cherry picked from commit bbfaeb0)
darwinsubramaniam
pushed a commit
to darwinsubramaniam/superset
that referenced
this pull request
Sep 7, 2023
eschutho
pushed a commit
that referenced
this pull request
Oct 20, 2023
eschutho
pushed a commit
that referenced
this pull request
Oct 20, 2023
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
mistercrunch
added
🍒 2.1.2
🍒 2.1.3
🍒 3.0.0
🍒 3.0.1
🍒 3.0.2
🍒 3.0.3
🍒 3.0.4
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for series limit subquery creation for databases that mutate labels.
Fixes #25073
SUMMARY
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION