Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Sunburst chart error when secondary metric is null #25159

Merged
merged 1 commit into from
Sep 1, 2023
Merged

fix: Sunburst chart error when secondary metric is null #25159

merged 1 commit into from
Sep 1, 2023

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Fixes an error in legacy Sunburst charts that happened when the secondary_metric was null. There are no tests for this specific viz and I didn't add one because this code is deprecated and will be removed in the next major release.

Fixes #25154

TESTING INSTRUCTIONS

Check the original issue for instructions.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@michael-s-molina michael-s-molina added the v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch label Sep 1, 2023
john-bodley
john-bodley approved these changes Sep 1, 2023
View reviewed changes
Copy link
Member

@john-bodley john-bodley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One could use the walrus operator, but given this is legacy code this LGTM.

@michael-s-molina michael-s-molina merged commit aea9167 into apache:master Sep 1, 2023
30 checks passed
michael-s-molina added a commit that referenced this pull request Sep 5, 2023
@michael-s-molina
fix: Sunburst chart error when secondary metric is null (#25159)
b53042a 
(cherry picked from commit aea9167)
darwinsubramaniam pushed a commit to darwinsubramaniam/superset that referenced this pull request Sep 7, 2023
@michael-s-molina @darwinsubramaniam
fix: Sunburst chart error when secondary metric is null (apache#25159)
a09e30b
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@michael-s-molina
fix: Sunburst chart error when secondary metric is null (apache#25159)
66f7e4c
@mistercrunch mistercrunch added 🍒 3.0.0 🍒 3.0.1 🍒 3.0.2 🍒 3.0.3 🍒 3.0.4 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@john-bodley john-bodley john-bodley approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch 🍒 3.0.0 🍒 3.0.1 🍒 3.0.2 🍒 3.0.3 🍒 3.0.4 🚢 3.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Legacy Sunburst chart not rendering when secondary_metrics is null in 3.0.0rc3
3 participants
@michael-s-molina @john-bodley @mistercrunch