Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: All values being selected in Select #25202

Merged
merged 1 commit into from
Sep 6, 2023
Merged

fix: All values being selected in Select #25202

merged 1 commit into from
Sep 6, 2023

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Fixes #25178.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen.Recording.2023-09-06.at.09.12.27.mov
Screen.Recording.2023-09-06.at.09.10.30.mov

TESTING INSTRUCTIONS

Check the original issue for instructions.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

kgabryje
kgabryje approved these changes Sep 6, 2023
View reviewed changes
Copy link
Member

@kgabryje kgabryje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michael-s-molina michael-s-molina mentioned this pull request Sep 6, 2023
Closed
@michael-s-molina michael-s-molina added the v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch label Sep 6, 2023
@Vitor-Avila
Copy link
Contributor

thank you so much, @michael-s-molina!!!

@michael-s-molina michael-s-molina merged commit e605d6d into apache:master Sep 6, 2023
27 checks passed
michael-s-molina added a commit that referenced this pull request Sep 6, 2023
@michael-s-molina
fix: All values being selected in Select (#25202)
d8c72b8 
(cherry picked from commit e605d6d)
@sadpandajoe
Copy link
Contributor

🏷️ preset:2023.35

sadpandajoe pushed a commit to preset-io/superset that referenced this pull request Sep 6, 2023
@michael-s-molina @sadpandajoe
fix: All values being selected in Select (apache#25202)
0777431 
(cherry picked from commit e605d6d)
@sadpandajoe
Copy link
Contributor

@michael-s-molina we've seen a few issues with the dropdown component, would adding component tests for that component be helpful in the future if we make another dropdown change to ensure everything is working normally?

darwinsubramaniam pushed a commit to darwinsubramaniam/superset that referenced this pull request Sep 7, 2023
@michael-s-molina @darwinsubramaniam
fix: All values being selected in Select (apache#25202)
6253d14
@michael-s-molina
Copy link
Member Author

michael-s-molina commented Sep 7, 2023 •
edited
Loading

@michael-s-molina we've seen a few issues with the dropdown component, would adding component tests for that component be helpful in the future if we make another dropdown change to ensure everything is working normally?

@sadpandajoe Adding tests is always helpful but keep in mind that the Select component is the most tested component of Superset with more than 50 tests. Many bugs come from components that wrap that component and change its core logic such as the SelectFilterPlugin.

sebastiankruk added a commit to sebastiankruk/superset that referenced this pull request Sep 9, 2023
@sebastiankruk @sandeep-patel11
@hughhhh @michael-s-molina @cmontemuino @dpgaspar @eschutho @justinpark @sfirke @betodealmeida @giftig @kgabryje @yousoph @villebro
sync (#160)
4463d38 
* fix: Issue apache#24493; Resolved report selection menu in chart and dashboard page (apache#25157)

* fix: DML failures in SQL Lab (apache#25190)

* fix: All values being selected in Select (apache#25202)

* docs: fix wrong type in PREFERRED_DATABASES example (apache#25200)

Signed-off-by: cmontemuino <1761056+cmontemuino@users.noreply.github.com>

* docs: add CVEs for 2.1.1 (apache#25206)

* chore: back port 2.1.1 doc changes (apache#25165)

* feat(sqllab): Show sql in the current result (apache#24787)

* docs(FAQ): add answer re: necessary specs, copy-edit existing answer (apache#24992)

* fix: `is_select` (apache#25189)

* fix: Cypress test to force mouseover (apache#25209)

* fix(sqllab): Force trino client async execution (apache#24859)

* fix: granularity_sqla and GENERIC_CHART_AXES (apache#25213)

* chore: Convert deckgl class components to functional (apache#25177)

* fix: Cypress test to force mouseover (follow-up) (apache#25223)

* fix(docs): Fixing a typo in README.md (apache#25216)

* chore(read_csv): remove deprecated argument (apache#25226)

* chore(trino): remove unnecessary index checks (apache#25211)

---------

Signed-off-by: cmontemuino <1761056+cmontemuino@users.noreply.github.com>
Co-authored-by: Sandeep Patel <33354423+suicide11@users.noreply.github.com>
Co-authored-by: Hugh A. Miles II <hughmil3s@gmail.com>
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
Co-authored-by: Carlos M <1761056+cmontemuino@users.noreply.github.com>
Co-authored-by: Daniel Vaz Gaspar <danielvazgaspar@gmail.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
Co-authored-by: JUST.in DO IT <justin.park@airbnb.com>
Co-authored-by: Sam Firke <sfirke@users.noreply.github.com>
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
Co-authored-by: Rob Moore <giftig@users.noreply.github.com>
Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com>
Co-authored-by: yousoph <sophieyou12@gmail.com>
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@michael-s-molina
fix: All values being selected in Select (apache#25202)
cf890d5
@mistercrunch mistercrunch added 🍒 3.0.0 🍒 3.0.1 🍒 3.0.2 🍒 3.0.3 🍒 3.0.4 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgabryje kgabryje kgabryje approved these changes

@geido geido geido approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset:2023.35 size/XS v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch 🍒 3.0.0 🍒 3.0.1 🍒 3.0.2 🍒 3.0.3 🍒 3.0.4 🚢 3.1.0
Projects
None yet
Milestone
No milestone
7 participants
@michael-s-molina @Vitor-Avila @sadpandajoe @kgabryje @geido @mistercrunch @jinghua-qa