fix: inability to remove chart filter when dashboard time filter is applied

[lilykuang]

SUMMARY

When a chart is added to a dashboard with a time range filter applied, adding an additional filter to the chart in Explore results in an issue where the added filter cannot be removed as expected.

Repro Steps:

1. Create a chart and add it to a dashboard. For example, a pie chart with video_game_sales, where the dimension is "genre" and the metric is "sum(global_sales)."
2. On the dashboard, apply a native filter for a time range, such as 1998-2023.
3. Click on the chart title to access it in Explore.
4. In Explore, add a new filter to the chart. In this case, add the filter "publisher in Nintendo"
5. Overwrite the chart and return to the dashboard.
6. Access the pie chart in Explore once more and attempt to remove the state filter. Overwrite the chart.

Expected Results:
The state filter should be removable from the chart after the second overwrite in step 5.

Actual Results:
Unfortunately, the state filter still persists, and it cannot be removed as expected.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

After:

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[yousoph]

/testenv up

[github-actions]

@yousoph Ephemeral environment spinning up at http://34.209.85.6:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[michael-s-molina]

@lilykuang the comment states:

Retain adhoc_filters from the slice if no adhoc_filters are present

but now we're only retaining temporal filters where !isExtra. Is this correct or do we also need to retain adhoc filters that are not temporal? If this is correct, can you adjust the comment to reflect the change?

[github-actions]

Ephemeral environment shutdown and build artifacts deleted.