chore(sqllab): Migrate tests to typescript #25274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| import HighlightedSql from 'src/SqlLab/components/HighlightedSql'; | ||
| import ModalTrigger from 'src/components/ModalTrigger'; | ||
| import { supersetTheme, ThemeProvider } from '@superset-ui/core'; | ||
| import { fireEvent, render } from 'spec/helpers/testing-library'; |
There was a problem hiding this comment.
Thank you @justinpark for the improvements! We generally avoid describe and it in RTL tests. Could you remove them?
There was a problem hiding this comment.
You can check our Testing Guidelines and Best Practices to improve even more the tests 😉
eschutho
pushed a commit
to Superset-Community-Partners/superset
that referenced
this pull request
Sep 21, 2023
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Migrates legacy jsx tests to typescript including replacing enzyme by testing-library.
TESTING INSTRUCTIONS
npm run type and test
ADDITIONAL INFORMATION