chore: Remove the ability to switch to filter-box chart when DASHBOARD_NATIVE_FILTERS feature is enabled #25275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-bodley
added
the
v3.0
justinpark
reviewed
Sep 12, 2023
superset-frontend/src/explore/components/controls/VizTypeControl/index.tsx
Outdated
Show resolved
Hide resolved
…D_NATIVE_FILTERS feature is enabled
john-bodley
force-pushed
the
john-bodley--fix-23142
branch
from
be3c0d3
to
329ff44
Compare
john-bodley
added a commit
to airbnb/superset-fork
that referenced
this pull request
Sep 12, 2023
…D_NATIVE_FILTERS feature is enabled (apache#25275) (cherry picked from commit 8eff5a7)
john-bodley
added a commit
to john-bodley/superset
that referenced
this pull request
Sep 13, 2023
…D_NATIVE_FILTERS feature is enabled (apache#25275) (cherry picked from commit 8eff5a7)
eschutho
pushed a commit
to Superset-Community-Partners/superset
that referenced
this pull request
Sep 21, 2023
…D_NATIVE_FILTERS feature is enabled (apache#25275)
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
…D_NATIVE_FILTERS feature is enabled (apache#25275)
mistercrunch
added
🍒 3.0.0
🍒 3.0.1
🍒 3.0.2
🍒 3.0.3
🍒 3.0.4
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR is a follow up to #23142. Previously I removed the ability to add a filter-box chart when the
DASHBOARD_NATIVE_FILTERSfeature was enabled, but neglected to take into account switching visualization types.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
BEFORE
AFTER
TESTING INSTRUCTIONS
Manual testing.
ADDITIONAL INFORMATION