feat: generic marshmallow error component #25303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
betodealmeida
force-pushed
the
sc_71594
branch
2 times, most recently
from
0816aa0
to
047f915
Compare
john-bodley
added
the
review:checkpoint
john-bodley
reviewed
Sep 14, 2023
betodealmeida
force-pushed
the
sc_71594
branch
from
047f915
to
2d03000
Compare
michael-s-molina
removed
the
review:checkpoint
hughhhh
reviewed
Sep 20, 2023
superset-frontend/src/components/Datasource/DatasourceModal.tsx
Outdated
Show resolved
Hide resolved
hughhhh
reviewed
Sep 20, 2023
superset-frontend/src/components/ErrorMessage/MarshmallowErrorMessage.tsx
Show resolved
Hide resolved
|
This is a really great improvement @betodealmeida! |
eschutho
reviewed
Sep 20, 2023
superset-frontend/src/components/Datasource/DatasourceModal.tsx
Outdated
Show resolved
Hide resolved
eschutho
reviewed
Sep 20, 2023
superset-frontend/src/components/ErrorMessage/MarshmallowErrorMessage.tsx
Show resolved
Hide resolved
eschutho
reviewed
Sep 20, 2023
superset-frontend/src/components/ErrorMessage/MarshmallowErrorMessage.tsx
Show resolved
Hide resolved
|
/testenv up |
|
@yousoph Ephemeral environment spinning up at http://35.165.15.14:8080. Credentials are |
betodealmeida
force-pushed
the
sc_71594
branch
2 times, most recently
from
66fc17e
to
e62bea2
Compare
betodealmeida
force-pushed
the
sc_71594
branch
from
e62bea2
to
edd7bf5
Compare
zephyring
reviewed
Oct 3, 2023
| @@ -88,7 +89,7 @@ export type ErrorType = ValueOf<typeof ErrorTypeEnum>; | |||
| // Keep in sync with superset/views/errors.py | |||
| export type ErrorLevel = 'info' | 'warning' | 'error'; | |||
|
|
|||
| export type ErrorSource = 'dashboard' | 'explore' | 'sqllab'; | |||
| export type ErrorSource = 'dashboard' | 'explore' | 'sqllab' | 'crud'; | |||
There was a problem hiding this comment.
crud doesn't seem like a domain source like others here. Is there a better name for this?
There was a problem hiding this comment.
Yeah, I couldn't think of a better name. The CRUD is one of the main domains, just not a fancy one. :-P
zephyring
approved these changes
Oct 3, 2023
lilykuang
approved these changes
Oct 3, 2023
hughhhh
reviewed
Oct 3, 2023
|
Ephemeral environment shutdown and build artifacts deleted. |
9 tasks
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Add better error handling for Marshmallow errors, with a custom exception, error, and React component.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION