Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(i18n): add ukranian translations #25323

Merged
merged 8 commits into from
Jan 29, 2024

Conversation

GlugovGrGlib
Copy link
Contributor

@GlugovGrGlib GlugovGrGlib commented Sep 16, 2023

SUMMARY

Adding initial version of the Ukrainian translations for the Superset. To translate phrases I used Google Translate, and after this manually checked most of the translations.

AFTER SCREENSHOTS

Screenshot 2023-09-17 at 01-16-05 USA Births Names
Screenshot 2023-09-17 at 01-16-34 Superset
Screenshot 2023-09-17 at 01-17-25 Superset
Screenshot 2023-09-17 at 01 17 10

TESTING INSTRUCTIONS

  • activate uk (Ukrainian) language in superset_config.py
  • open the dashboard, navigate through the system

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

Copy link

@mlisivka mlisivka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just looked through some of the translations.

I think the word "дашборд" is good to change "панель" or "табло" or a bit different "упорядник"

Also, I found that you use 2 different words for "Chart": "Діаграма" and "Графік". I think "Діаграма" is more general and fits better

"1 hour": ["1 година"],
"1 hourly frequency": ["1 погодинна частота"],
"1 minute": ["1 хвилина"],
"1 minutely frequency": ["1 Частотна частота"],

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"1 minutely frequency": ["1 Частотна частота"],
"1 minutely frequency": ["1 хвилинна частота"],

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, updated

"1M": ["1M"],
"1T": ["1T"],
"2 years": ["2 роки"],
"2 years ago": ["2 роки назад"],

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"2 years ago": ["2 роки назад"],
"2 years ago": ["2 роки тому"],

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

"A handlebars template that is applied to the data": [
"Шаблон ручки, який застосовується до даних"
],
"A human-friendly name": ["Ім'я зручної для людини"],

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better to have
"Ім'я, що зручне для людини"
Or
"Зручне для людини ім'я"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed

"AXIS TITLE POSITION": ["Позиція заголовка вісь"],
"About": ["Про"],
"Access": ["Доступ"],
"Access requests": ["Запити на доступ до доступу"],

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"Access requests": ["Запити на доступ до доступу"],
"Access requests": ["Запити доступу"],

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed this

"Add new formatter": ["Додати новий форматер"],
"Add notification method": ["Додайте метод сповіщення"],
"Add required control values to preview chart": [
"Додайте необхідні контрольні значення до діаграми попереднього перегляду"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"Додайте необхідні контрольні значення до діаграми попереднього перегляду"
"Додайте необхідні контрольні значення для попереднього перегляду діаграми"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, updated

@GlugovGrGlib
Copy link
Contributor Author

I just looked through some of the translations.

I think the word "дашборд" is good to change "панель" or "табло" or a bit different "упорядник"

Also, I found that you use 2 different words for "Chart": "Діаграма" and "Графік". I think "Діаграма" is more general and fits better

Thank you, I fixed Chart translations. As per “Dashboard” I am working on translating it to “Інформаційна Панель” throughout the pages.

@michael-s-molina
Copy link
Member

@mlisivka I don't speak Ukranian, can you review the PR and approve it if everything is ok?

@mlisivka
Copy link

@michael-s-molina OK, but it will take some time for me, probably weeks. Ok?

Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rusackas rusackas merged commit 29bc68b into apache:master Jan 29, 2024
33 checks passed
@rusackas
Copy link
Member

It seems this PR was getting stuck, and I didn't want to lose all this value in a conflict or something. The net benefit seems very high, even if there are a few things to correct in follow-up PRs. Please do open as many PRs as you'd like to make corrections and improve the situation.

eschutho pushed a commit to preset-io/superset that referenced this pull request Jan 31, 2024
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.0.0 labels Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XXL 🚢 4.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants