Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sqllab): extra logging when chart is downloaded #25345

Merged
merged 3 commits into from
Sep 21, 2023

Conversation

zephyring
Copy link
Contributor

@zephyring zephyring commented Sep 19, 2023

SUMMARY

  1. add logging for when chart is downloaded as image, json, csv, xls
  2. it will call the superset/log endpoint with form_data payload like
[{
  "source":"explore", 
  "source_id":80,
  "event_name":"chart_download_as_json",
  "chartId":80,
  "chartName":"a chart name",
  "event_type":"user"
  ...
}]

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@zephyring zephyring changed the title feat: extra logging when chart is downloaded feat(sqllab): extra logging when chart is downloaded Sep 19, 2023
@zephyring zephyring marked this pull request as ready for review September 20, 2023 21:50
@lilykuang lilykuang merged commit 16f31f8 into apache:master Sep 21, 2023
26 checks passed
@lilykuang lilykuang deleted the zef/extra_logging_chart_download branch September 21, 2023 16:43
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 3.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants