Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(helm): spelling: initialize #25455

Merged
merged 1 commit into from
Oct 13, 2023
Merged

chore(helm): spelling: initialize #25455

merged 1 commit into from
Oct 13, 2023

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Sep 28, 2023

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@john-bodley
Copy link
Member

Thanks @jsoref for the change. Would you mind fixing the failed CI check?

@jsoref
Copy link
Contributor Author

jsoref commented Sep 29, 2023

I couldn't figure out how, it wasn't obvious. If you explain, I might have ~5mins today, otherwise Monday.

@craig-rueda
Copy link
Member

Please run helm-docs against the helm folder (https://github.com/norwoodj/helm-docs#installation)

dpgaspar
dpgaspar reviewed Oct 13, 2023
View reviewed changes
Copy link
Member

@dpgaspar dpgaspar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current chart version on master is 0.10.9, https://github.com/apache/superset/blob/master/helm/superset/Chart.yaml#L32

You probably need to rebase

@jsoref jsoref force-pushed the spelling-helm branch 2 times, most recently from d1410cc to 89e0ad0 Compare October 13, 2023 10:48
dpgaspar
dpgaspar approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@dpgaspar dpgaspar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank you

@jsoref
spelling: initialize
5557ebb 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@craig-rueda craig-rueda merged commit bfcca8c into apache:master Oct 13, 2023
26 checks passed
@jsoref jsoref deleted the spelling-helm branch October 13, 2023 16:57
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@jsoref
chore(helm): spelling: initialize (apache#25455)
ffb597d 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
@jsoref @sfirke
chore(helm): spelling: initialize (apache#25455)
3171b94 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@craig-rueda craig-rueda craig-rueda approved these changes

@dpgaspar dpgaspar dpgaspar approved these changes

@villebro villebro Awaiting requested review from villebro villebro is a code owner

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 3.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jsoref @john-bodley @craig-rueda @dpgaspar @mistercrunch