fix(tags): Update loading + pagination for Tags Page #25473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hughhhh
changed the title
|
@hughhhh would you mind filling out the PR description. |
eschutho
reviewed
Oct 2, 2023
| const showListViewObjs = | ||
| objects.dashboard.length > 0 || | ||
| objects.chart.length > 0 || | ||
| objects.query.length > 0; | ||
|
|
||
| useEffect(() => { | ||
| console.log(search); |
There was a problem hiding this comment.
Suggested change
| console.log(search); |
eschutho
reviewed
Oct 2, 2023
| // addDangerToast('Error Fetching Tagged Objects'); | ||
| // logging.log(error.text); | ||
| // }, | ||
| // ); |
| @@ -30,6 +30,7 @@ import { EmptyStateBig } from 'src/components/EmptyState'; | |||
| import { fetchObjects } from '../tags/tags'; | |||
|
|
|||
| const MAX_TAGS_TO_SHOW = 3; | |||
| const PAGE_SIZE = 5; | |||
There was a problem hiding this comment.
Should this be 50, like before?
There was a problem hiding this comment.
design wants this to be 10 since there are 3 tables on the 1 page
hughhhh
force-pushed
the
tags-pagination
branch
from
ab91cbc
to
a1fca2a
Compare
lilykuang
reviewed
Oct 4, 2023
| fetchSingleTag( | ||
| tagId, | ||
| (tag: Tag) => { | ||
| setTag(tag); | ||
| setLoading(false); | ||
| }, | ||
| (error: Response) => { | ||
| addDangerToast(t('Error Fetching Tagged Objects')); |
lilykuang
reviewed
Oct 4, 2023
| setLoading(false); | ||
| }, | ||
| (error: Response) => { | ||
| addDangerToast('Error Fetching Tagged Objects'); |
There was a problem hiding this comment.
you might need to add setLoading(false); here to prevent the spinner kept spinning
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Added pagination to Tags.AllEntities page and fixed loading to stop flickering on component mounting
BEFORE/AFTER
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION