Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add https & ldap instructions #25477

Merged
merged 4 commits into from
Oct 3, 2023
Merged

docs: add https & ldap instructions #25477

merged 4 commits into from
Oct 3, 2023

Conversation

mdeshmu
Copy link
Contributor

@mdeshmu mdeshmu commented Oct 1, 2023 •
edited
Loading

SUMMARY

Address bugherd task 51 & 59

cc: @sfirke @rusackas

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@mdeshmu mdeshmu changed the title add https guidelines docs: add https guidelines Oct 1, 2023
@pull-request-size pull-request-size bot added size/S and removed size/XS labels Oct 1, 2023
@mdeshmu mdeshmu changed the title docs: add https guidelines docs: add https & ldap instructions Oct 1, 2023
@mdeshmu mdeshmu mentioned this pull request Oct 1, 2023
Closed
9 tasks
@mdeshmu
Copy link
Contributor Author

mdeshmu commented Oct 2, 2023

pre-commit failure is not related to this PR.

tests/unit_tests/db_engine_specs/test_clickhouse.py:66: error: Argument 1 to "NewConnectionError" has incompatible type "str"; expected "HTTPConnection" [arg-type]

sfirke
sfirke reviewed Oct 2, 2023
View reviewed changes
Copy link
Member

@sfirke sfirke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I made one change commit and then left a suggestion for another change. Once that suggestion is resolved then I'm good to merge this. I wonder if this Custom OAuth2 and LDAP stuff belongs on the Security page instead, but it's a good starting point to have it here.

docs/docs/installation/configuring-superset.mdx Outdated Show resolved Hide resolved
docs/docs/installation/configuring-superset.mdx Show resolved Hide resolved
@mdeshmu mdeshmu requested a review from sfirke October 3, 2023 02:49
@mdeshmu
Copy link
Contributor Author

mdeshmu commented Oct 3, 2023

This is ready to merge

@sfirke sfirke merged commit c52c206 into apache:master Oct 3, 2023
28 checks passed
@mdeshmu mdeshmu deleted the bugherd-51 branch October 13, 2023 15:26
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mdeshmu @sfirke
docs: add https & ldap instructions (apache#25477)
7168412 
Co-authored-by: Sam Firke <sfirke@users.noreply.github.com>
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfirke sfirke sfirke approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 3.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mdeshmu @sfirke @mistercrunch