fix(menu): Styling active menu in SPA navigation #25533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinpark
changed the title
john-bodley
added
the
review:checkpoint
justinpark
removed
the
review:checkpoint
|
Hi @michael-s-molina @john-bodley @craig-rueda! Can you approve this PR? |
| @@ -154,6 +154,29 @@ const globalStyles = (theme: SupersetTheme) => css` | |||
| margin-left: ${theme.gridUnit * 1.75}px; | |||
| } | |||
| } | |||
| .ant-menu-item-selected { | |||
| background-color: transparent !important; | |||
There was a problem hiding this comment.
Is it possible to avoid !important here? Maybe using a more specific class?
There was a problem hiding this comment.
@michael-s-molina I just removed all these redundant !important
michael-s-molina
added
the
v3.1
michael-s-molina
pushed a commit
that referenced
this pull request
Dec 8, 2023
(cherry picked from commit 86304ab)
josedev-union
pushed a commit
to Ortege-xyz/studio
that referenced
this pull request
Jan 22, 2024
(cherry picked from commit 86304ab)
mistercrunch
added
🍒 3.1.0
🍒 3.1.1
🏷️ bot
sfirke
pushed a commit
to sfirke/superset
that referenced
this pull request
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes the addressed issue (no. 2) on #25151 (comment)
This commit replaces Link with NavLink to fix outdated highlighted menu. This commit replaces the ant-menu-item-selected style by NavLink active style to sync the router active link status.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
before--navlink.mov
After:
after--navlink.mov
TESTING INSTRUCTIONS
Click Chart (or Dashboard) link
Click Query History menu under the SQL Link
Navigate back by the browser button
See the highlighted menu on the header
ADDITIONAL INFORMATION