Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sqllab): Add keyboard shortcut helper #25542

Merged

Conversation

justinpark
Copy link
Member

SUMMARY

This commit adds keyboard shortcut helper button to display keyboard shortcut list.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

after--keyboard-shortcut.mov

TESTING INSTRUCTIONS

Go to SQL Lab and click shortcut button

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@justinpark
Copy link
Member Author

@kasiazjc could you help the design review?

@eschutho
Copy link
Member

eschutho commented Oct 6, 2023

@justinpark This is really cool!

@eschutho
Copy link
Member

eschutho commented Oct 6, 2023

/testenv up

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2023

@eschutho Ephemeral environment spinning up at http://34.216.203.161:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@yousoph
Copy link
Member

yousoph commented Oct 10, 2023

Not sure if this is due to this PR or not, but when I first go to SQL Lab on the ephemeral, the tabs don't load:
image

After refreshing it works fine... 🤔

@kasiazjc
Copy link
Contributor

kasiazjc commented Oct 11, 2023

@justinpark thank you for working on this, definitely a needed feature! I have a few suggestions:

  • I would switch the columns on action and shortcut - it is easier to scan the text and look for keywords that way, and we do not have to worry about truncation if there are more than 2 shortcuts
image
  • I changed shortcut fontsize to 12px - 14px seemed to be overly cluttering the modal

  • I think this feature is not needed to be available at all times - people will probably quickly learn shortcuts and only open the modal to refresh the memory, so I would suggest moving it to the "..." dropdown with autocomplete, as this bar has a bunch of buttons already

What do you think?

@justinpark justinpark force-pushed the feat--add-keyboard-shortcut-screen branch from 39e202f to 29c4bea Compare October 11, 2023 14:41
@justinpark
Copy link
Member Author

  • I would switch the columns on action and shortcut - it is easier to scan the text and look for keywords that way, and we do not have to worry about truncation if there are more than 2 shortcuts
image * I changed shortcut fontsize to 12px - 14px seemed to be overly cluttering the modal * I think this feature is not needed to be available at all times - people will probably quickly learn shortcuts and only open the modal to refresh the memory, so I would suggest moving it to the "..." dropdown with autocomplete, as this bar has a bunch of buttons already

What do you think?

@kasiazjc Thanks for the suggestion! I made the layout change and menu location as you suggested.
Screenshot 2023-10-11 at 10 39 04 AM

Screenshot 2023-10-11 at 9 14 29 AM

@justinpark
Copy link
Member Author

Not sure if this is due to this PR or not, but when I first go to SQL Lab on the ephemeral, the tabs don't load:

I don't find the issue.
I believe that's caused by the previous ephemeral cache.
Please re-create ephemeral test environment and test again if you concern about it.

@kasiazjc
Copy link
Contributor

  • I would switch the columns on action and shortcut - it is easier to scan the text and look for keywords that way, and we do not have to worry about truncation if there are more than 2 shortcuts
image * I changed shortcut fontsize to 12px - 14px seemed to be overly cluttering the modal * I think this feature is not needed to be available at all times - people will probably quickly learn shortcuts and only open the modal to refresh the memory, so I would suggest moving it to the "..." dropdown with autocomplete, as this bar has a bunch of buttons already What do you think?

@kasiazjc Thanks for the suggestion! I made the layout change and menu location as you suggested. Screenshot 2023-10-11 at 10 39 04 AM

Screenshot 2023-10-11 at 9 14 29 AM

Thank you for the quick changes, this looks great!

Copy link
Contributor

@kasiazjc kasiazjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

design LGTM

@justinpark justinpark merged commit 2dc5c5f into apache:master Oct 12, 2023
26 checks passed
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 3.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants