Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Cleanup hostNamesConfig.js #25543

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

john-bodley
Copy link
Member

SUMMARY

Flexing my very limited frontend knowledge to cleanup checking for whether bootstrapData.common.conf.SUPERSET_WEBSERVER_DOMAINS is defined.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

CI.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Merging #25543 (df5beae) into master (0c40bea) will increase coverage by 0.61%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #25543      +/-   ##
==========================================
+ Coverage   68.51%   69.13%   +0.61%     
==========================================
  Files        1915     1915              
  Lines       75100    75100              
  Branches     8314     8314              
==========================================
+ Hits        51455    51920     +465     
+ Misses      21503    21038     -465     
  Partials     2142     2142              
Flag Coverage Δ
hive 53.68% <ø> (ø)
javascript 56.32% <100.00%> (+<0.01%) ⬆️
mysql 78.34% <ø> (?)
postgres 78.44% <ø> (?)
presto 53.63% <ø> (ø)
python 82.86% <ø> (+1.27%) ⬆️
sqlite 77.08% <ø> (ø)
unit 55.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
superset-frontend/src/utils/hostNamesConfig.js 73.33% <100.00%> (ø)

... and 38 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@john-bodley john-bodley merged commit 32e37d8 into master Oct 17, 2023
52 checks passed
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
@mistercrunch mistercrunch deleted the john-bodley--cleanup-host-names-config branch March 26, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 3.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants