chore: Update pylint to 2.17.7 #25566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@villebro @john-bodley @michael-s-molina Merge it? |
john-bodley
reviewed
Oct 9, 2023
| @@ -75,7 +75,6 @@ enable= | |||
| # --disable=W" | |||
| disable= | |||
| cyclic-import, # re-enable once this no longer raises false positives | |||
| no-member, # re-enable once this no longer raises false positives. This will become redundant after the min required version is 3.11 | |||
There was a problem hiding this comment.
@EugeneTorap personally I think it is preferable to keep this disables inline. We use the useless-suppression check so when we upgrade to Python 3.11 as a minimum the check will fire. It seems like an cleaner/safer cleanup mechanism that leaving notes in the code.
There was a problem hiding this comment.
@john-bodley Please, check this #24803 PR. We added this line there.
There was a problem hiding this comment.
Apologies @EugeneTorap. I misread this as an addition as opposed to a removal.
john-bodley
approved these changes
Oct 9, 2023
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
mistercrunch
added
🏷️ bot
sfirke
pushed a commit
to sfirke/superset
that referenced
this pull request
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Bump pylint to 2.17.7 in order to fix the next false positive pylint issue for Enum
pylint-dev/pylint#8897 was resolved (created by @mdeshmu)
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION