-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tags): +n tags for listview #25603
Conversation
/testenv TAGGING_SYSTEM=True |
/testenv up TAGGING_SYSTEM=true |
@hughhhh Ephemeral environment spinning up at http://34.221.218.192:8080. Credentials are |
target="_blank" | ||
rel="noreferrer" | ||
> | ||
{isLongTag ? `${name.slice(0, 20)}...` : name} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we put a const at the top holding this 20
? I see we're using it in a few places and would be good to just update it once if needed. Or instead of having a isLongTag
bool, why not just truncating the name altogether and use that when rendering? if it's a long tag we are always truncating it either way.
) : ( | ||
tagElem | ||
); | ||
return tagElem; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have a test asserting we are rendering the "short" version of the tag when needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, after fixing the tests it should be fine.
Ephemeral environment shutdown and build artifacts deleted. |
SUMMARY
Fix tooltip to render info about tag in collapse and overall naming even if it's long
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION