Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: make project-specific security page more prominent #25654

Conversation

raboof
Copy link
Member

@raboof raboof commented Oct 16, 2023

SUMMARY

Link to https://superset.apache.org/docs/security/ so people are directed to the detailed SuperSet-specific security documentation. Link from there to the ASF-wide information.

TESTING INSTRUCTIONS

Build the website, see the footer.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

Copy link
Member

@sfirke sfirke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfirke
Copy link
Member

sfirke commented Oct 16, 2023

This is an improvement as far as I'm concerned, I think it's more likely that someone on the Superset project docs will be looking for Superset's security info, not the ASF's. The rest of those links are ASF-level, but that makes sense. Let's just ping @rusackas who is on the Superset PMC and closer to the ASF and get his take before merging.

Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfirke sfirke merged commit 150e5c9 into apache:master Oct 17, 2023
29 checks passed
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 3.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants