feat: Funnel/tooltip-customization #25666
Conversation
|
/testenv up |
|
@yousoph Ephemeral environment spinning up at http://54.245.25.94:8080. Credentials are |
|
Could you update the default for the tooltip contents to be "Category, Value, and Percentage" so it's in line with what the tooltips contain today? |
There was a problem hiding this comment.
Thank you for the improvement @CorbinBullard. I left some first-pass comments.
superset-frontend/plugins/plugin-chart-echarts/src/Funnel/transformProps.ts
Outdated
Show resolved
Hide resolved
superset-frontend/plugins/plugin-chart-echarts/src/Funnel/controlPanel.tsx
Outdated
Show resolved
Hide resolved
superset-frontend/plugins/plugin-chart-echarts/src/Funnel/controlPanel.tsx
Outdated
Show resolved
Hide resolved
superset-frontend/plugins/plugin-chart-echarts/src/Funnel/controlPanel.tsx
Outdated
Show resolved
Hide resolved
superset-frontend/plugins/plugin-chart-echarts/src/Funnel/controlPanel.tsx
Outdated
Show resolved
Hide resolved
| t('Category, Value and Percentage'), | ||
| ], | ||
| ], | ||
| description: t('What should be shown as the tooltip Label'), |
There was a problem hiding this comment.
| description: t('What should be shown as the tooltip Label'), | |
| description: t('What should be shown as the tooltip label'), |
|
Ephemeral environment shutdown and build artifacts deleted. |
|
This is an awesome feature. Can this be extended to all popular charts? |
I hate to be "that guy" on the open-source project, but we'd be happy to review PRs for this from you or anyone reading this. Hopefully this can be followed up on as an example implementation. |
mistercrunch
added
🏷️ bot
SUMMARY
Added customization to funnel chart tooltips as well as the option to disable the tooltip
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
BEFORE:
AFTER: