Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style(readme): reformatted #25721

Merged
merged 1 commit into from
Oct 24, 2023
Merged

style(readme): reformatted #25721

merged 1 commit into from
Oct 24, 2023

Conversation

bipinct
Copy link
Contributor

@bipinct bipinct commented Oct 20, 2023 •
edited
Loading

SUMMARY

Removed picture tag displaying as text above Superset logo for better readability.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE
with

AFTER
without

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

github-actions[bot]
github-actions bot reviewed Oct 20, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

john-bodley
john-bodley approved these changes Oct 20, 2023
View reviewed changes
Copy link
Member

@john-bodley john-bodley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bipinct for the fix.

@rusackas rusackas merged commit 27a06f5 into apache:master Oct 24, 2023
29 checks passed
@john-bodley john-bodley mentioned this pull request Oct 26, 2023
Merged
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@bipinct
style(readme): reformatted (apache#25721)
669ab8d
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
@bipinct @sfirke
style(readme): reformatted (apache#25721)
0e8d525
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions left review comments

@john-bodley john-bodley john-bodley approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 3.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bipinct @john-bodley @mistercrunch @rusackas