Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump pymssql version #25737

Merged
merged 2 commits into from
Oct 24, 2023
Merged

chore: bump pymssql version #25737

merged 2 commits into from
Oct 24, 2023

Conversation

gnought
Copy link
Contributor

@gnought gnought commented Oct 23, 2023

SUMMARY

pymssql >=2.2.8 is required to compatible with cython v3 pymssql/pymssql#803

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@gnought
bump pymssql version
93c6df0 
pymssql >=2.2.8 is required to compatible with cython v3 ttps://github.com/pymssql/pymssql/pull/803
@john-bodley john-bodley added the review:checkpoint Last PR reviewed during the daily review standup label Oct 23, 2023
john-bodley
john-bodley reviewed Oct 23, 2023
View reviewed changes
Copy link
Member

@john-bodley john-bodley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gnought for the PR. I've left an inline comment, but could you also update the PR title/description to ensure CI passes.

setup.py Outdated Show resolved Hide resolved
@gnought gnought changed the title bump pymssql version chore: bump pymssql version Oct 24, 2023
@gnought
Copy link
Contributor Author

gnought commented Oct 24, 2023

@john-bodley fixed, all checks are passed.

@john-bodley john-bodley merged commit 419d122 into apache:master Oct 24, 2023
26 checks passed
@gnought gnought deleted the patch-1 branch October 24, 2023 09:24
@john-bodley john-bodley removed the review:checkpoint Last PR reviewed during the daily review standup label Oct 26, 2023
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@gnought
chore: bump pymssql version (apache#25737)
ea5689a
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
@gnought @sfirke
chore: bump pymssql version (apache#25737)
49e561a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@john-bodley john-bodley john-bodley approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 3.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gnought @john-bodley @mistercrunch