chore(docker-compose): more host network specifiers #25817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add host network to the app and worker containers as well, so that it's possible to connect a native database to superset running in docker-compose. Makes the dev environment a bit easier to work with and has no real drawbacks.
giftig
force-pushed
the
chore-host-networks
branch
from
2bf4dbc
to
137b354
Compare
giftig
changed the title
craig-rueda
approved these changes
Nov 2, 2023
|
LGTM |
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
mistercrunch
added
🏷️ bot
sfirke
pushed a commit
to sfirke/superset
that referenced
this pull request
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add host network to the app and worker containers as well, so that it's possible to connect a native database to superset running in docker-compose. Makes the dev environment a bit easier to work with and has no real drawbacks.
TESTING INSTRUCTIONS
Run superset with docker-compose
ADDITIONAL INFORMATION