Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update sip.md to have a better call to action #25822

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

rusackas
Copy link
Member

@rusackas rusackas commented Nov 1, 2023

SUMMARY

Changing the Issues template to be more descriptive about SIPs

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@rusackas rusackas changed the title Update sip.md to have a better call to action chore: Update sip.md to have a better call to action Nov 1, 2023
Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Merging #25822 (d0edc45) into master (e1eb985) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #25822      +/-   ##
==========================================
- Coverage   68.97%   68.94%   -0.04%     
==========================================
  Files        1938     1938              
  Lines       75611    75611              
  Branches     8417     8417              
==========================================
- Hits        52151    52128      -23     
- Misses      21299    21322      +23     
  Partials     2161     2161              
Flag Coverage Δ
hive 53.68% <ø> (ø)
javascript 56.19% <ø> (ø)
mysql 78.37% <ø> (?)
postgres ?
presto 53.63% <ø> (ø)
python 82.74% <ø> (-0.07%) ⬇️
unit 55.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 22 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rusackas rusackas merged commit a368645 into master Nov 1, 2023
53 of 54 checks passed
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
@mistercrunch mistercrunch deleted the rusackas-patch-1 branch March 26, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 3.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants