Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(charts): Time grain is None when dataset uses Jinja #25842

Merged
merged 2 commits into from
Nov 6, 2023
Merged

fix(charts): Time grain is None when dataset uses Jinja #25842

merged 2 commits into from
Nov 6, 2023

Commits on Nov 2, 2023

  1. fix(charts): Time grain is None when dataset uses Jinja 

    - Ensure that extras.time_grain_sqla is not omitted when GENERIC_CHART_AXES is enabled to allow charts to correctly apply time grain when the underlying dataset uses Jinja.
    @Antonio-RiveroMartnez
    Antonio-RiveroMartnez committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    c18d298 View commit details
    Browse the repository at this point in the history

  2. fix(charts): Time grain is None when dataset uses Jinja 

    - Fix tests
    @Antonio-RiveroMartnez
    Antonio-RiveroMartnez committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    d2fdb05 View commit details
    Browse the repository at this point in the history