feat(sqllab): Dynamic query limit dropdown #25855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging @justinpark since I see you were the author of this file. |
giftig
force-pushed
the
better-query-limit
branch
from
d4c42f5
to
52fdf03
Compare
john-bodley
reviewed
Nov 3, 2023
| const dropdown = baseElement.getElementsByClassName( | ||
| 'ant-dropdown-trigger', | ||
| )[0]; | ||
|
|
||
| userEvent.click(dropdown); | ||
| await waitFor(() => expect(getByRole('menu')).toBeInTheDocument()); | ||
|
|
||
| const expectedLabels = [10, 100, 1000, 10000, 50000].map(i => |
There was a problem hiding this comment.
@giftig would you also mind adding a couple of tests: i) when maxRow is a factor of 10, and ii) when the maxRow is less than 10?
giftig
force-pushed
the
better-query-limit
branch
from
52fdf03
to
8e7cfd1
Compare
Previously, this was a constant of powers of ten from 10 to 100000 and then we tacked on maxRow on the end, being the SQL_MAX_ROW config. This unfortunately results is very confusing behaviour if SQL_MAX_ROW is less than 100,000 as it still let you select 100,000, though wouldn't acctually use that LIMIT, and the messaging would not acknowledge the setting for SQL_MAX_ROW either. Instead, construct the list by ascending through powers of ten until we reach the configured SQL_MAX_ROW.
giftig
force-pushed
the
better-query-limit
branch
from
8e7cfd1
to
9f92fff
Compare
john-bodley
approved these changes
Nov 6, 2023
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
mistercrunch
added
🏷️ bot
sfirke
pushed a commit
to sfirke/superset
that referenced
this pull request
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Previously, this was a constant of powers of ten from 10 to 100000 and then we tacked on maxRow on the end, being the SQL_MAX_ROW config. This unfortunately results is very confusing behaviour if SQL_MAX_ROW is less than 100,000 as it still let you select 100,000, though wouldn't acctually use that LIMIT, and the messaging would not acknowledge the setting for SQL_MAX_ROW either.
Instead, construct the list by ascending through powers of ten until we reach the configured SQL_MAX_ROW.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before
After
TESTING INSTRUCTIONS
SQL_MAX_ROWto a value less than 100,000 or greater than 1,000,000SQL_MAX_ROW, and will display every power of 10 up toSQL_MAX_ROWADDITIONAL INFORMATION