Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sqllab): Show duration as separate column in Query History view #25861

Merged
merged 3 commits into from
Nov 20, 2023
Merged

feat(sqllab): Show duration as separate column in Query History view #25861

merged 3 commits into from
Nov 20, 2023

Conversation

sebastianliebscher
Copy link
Contributor

@sebastianliebscher sebastianliebscher commented Nov 4, 2023 •
edited
Loading

SUMMARY

Show Duration as separate column in Query History view instead of as a tooltip on the Time column.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

before:
image

after:
image

TESTING INSTRUCTIONS

  • GitHub CI

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@eschutho
Copy link
Member

eschutho commented Nov 4, 2023

This looks like a great improvement. Thanks @sebastianliebscher! Cc @yousoph and @kasiazjc

@yousoph
Copy link
Member

yousoph commented Nov 15, 2023

Looks good, thanks for the contribution!

justinpark
justinpark approved these changes Nov 17, 2023
View reviewed changes
Copy link
Member

@justinpark justinpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rusackas rusackas merged commit 92ac6b2 into apache:master Nov 20, 2023
28 checks passed
josedev-union pushed a commit to Ortege-xyz/studio that referenced this pull request Jan 22, 2024
@sebastianliebscher @josedev-union
feat(sqllab): Show duration as separate column in Query History view (a…
7fae23a 
…pache#25861)
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@sebastianliebscher
feat(sqllab): Show duration as separate column in Query History view (a…
00a9670 
…pache#25861)
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
@sebastianliebscher @sfirke
feat(sqllab): Show duration as separate column in Query History view (a…
7d22aed 
…pache#25861)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinpark justinpark justinpark approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 3.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@sebastianliebscher @eschutho @yousoph @justinpark @mistercrunch @rusackas