feat: method for dynamic allows_alias_in_select
#25882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
betodealmeida
changed the title
allows_alias_in_select
betodealmeida
force-pushed
the
sc-76228
branch
from
dca55fb
to
491a2ce
Compare
betodealmeida
commented
Nov 6, 2023
| @@ -765,7 +765,7 @@ def db_engine_spec(self) -> builtins.type["BaseEngineSpec"]: | |||
| raise NotImplementedError() | |||
|
|
|||
| @property | |||
| def database(self) -> builtins.type["Database"]: | |||
There was a problem hiding this comment.
This was wrong, but was hidden by a bunch of # type: ignore comments.
betodealmeida
force-pushed
the
sc-76228
branch
from
f9c6975
to
7f6b422
Compare
jinghua-qa
pushed a commit
to preset-io/superset
that referenced
this pull request
Nov 8, 2023
(cherry picked from commit 80caba3)
josedev-union
pushed a commit
to Ortege-xyz/studio
that referenced
this pull request
Jan 22, 2024
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
mistercrunch
added
🏷️ bot
sfirke
pushed a commit
to sfirke/superset
that referenced
this pull request
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
DB engine specs have an attribute called
allows_alias_in_select, indicating if they support aliases inSELECTstatements. For Dremio, this attribute is version dependent — see the fix in their release notes.Because of that, we've been ping-ponging on the attribute. First I disabled it in #23872, and later it was re-enabled in #25657 when the fix came out. Since we have Superset users running older versions, I added a new class method
get_allows_alias_in_select, that uses theversionfield in the database extra configuration.Note that this requires users running Dremio < 24.1.0 to explicitly add the
versionfield when configuring their databases. I'm not sure if we could determine the version at runtime, but even if we could it would require us to run a pre-query every time, which is needlessly expensive.Also note that the
versionfield is already used in Presto for version-dependent features.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION