chore: remove deprecated functions in SQLAlchemy #25911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is fantastic, thanks for the support in this area! |
john-bodley
reviewed
Nov 8, 2023
| @@ -167,21 +165,20 @@ def get_available_engine_specs() -> dict[type[BaseEngineSpec], set[str]]: | |||
| driver = driver.decode() | |||
| drivers[backend].add(driver) | |||
|
|
|||
| dbs_denylist = app.config["DBS_AVAILABLE_DENYLIST"] | |||
There was a problem hiding this comment.
Thanks for moving this outside of the loop.
john-bodley
approved these changes
Nov 8, 2023
josedev-union
pushed a commit
to Ortege-xyz/studio
that referenced
this pull request
Jan 22, 2024
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
mistercrunch
added
🏷️ bot
sfirke
pushed a commit
to sfirke/superset
that referenced
this pull request
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
SQLAlchemy 1.4 deprecates
sqlalchemy.databasespackages in favour ofsqlalchemy.dialectshttps://github.com/sqlalchemy/sqlalchemy/blob/9bafbd339e66177b14de71904a2c0e426ea0c711/lib/sqlalchemy/databases/__init__.py#L35-L38
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION