Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: removing unused chartMetadata field #25926

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

rusackas
Copy link
Member

@rusackas rusackas commented Nov 9, 2023

SUMMARY

In auditing plugin framework code, it seems the chartMetadata field show is not being used anywhere. Let's trim the fat!

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Merging #25926 (72b869f) into master (2bd6119) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #25926      +/-   ##
==========================================
- Coverage   69.04%   69.02%   -0.02%     
==========================================
  Files        1938     1938              
  Lines       75842    75840       -2     
  Branches     8426     8425       -1     
==========================================
- Hits        52363    52349      -14     
- Misses      21309    21321      +12     
  Partials     2170     2170              
Flag Coverage Δ
hive 53.65% <ø> (ø)
mysql ?
postgres 78.31% <ø> (-0.02%) ⬇️
presto 53.60% <ø> (ø)
python 82.83% <ø> (-0.04%) ⬇️
sqlite 76.97% <ø> (ø)
unit 55.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...superset-ui-core/src/chart/models/ChartMetadata.ts 100.00% <ø> (ø)

... and 6 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rusackas rusackas merged commit b6fb36f into master Nov 9, 2023
52 checks passed
josedev-union pushed a commit to Ortege-xyz/studio that referenced this pull request Jan 22, 2024
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
@mistercrunch mistercrunch deleted the removing-chartmetadata-show-field branch March 26, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 3.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants