chore: harmonize and clean up list views

superset-frontend/cypress-base/cypress/e2e/alerts_and_reports/alerts.test.ts

@@ -29,10 +29,9 @@ describe('Alert list view', () => {
     cy.getBySel('sort-header').eq(2).contains('Name');
     cy.getBySel('sort-header').eq(3).contains('Schedule');
     cy.getBySel('sort-header').eq(4).contains('Notification method');
-    cy.getBySel('sort-header').eq(5).contains('Created by');
-    cy.getBySel('sort-header').eq(6).contains('Owners');
-    cy.getBySel('sort-header').eq(7).contains('Modified');
-    cy.getBySel('sort-header').eq(8).contains('Active');
+    cy.getBySel('sort-header').eq(5).contains('Owners');
+    cy.getBySel('sort-header').eq(6).contains('Last modified');
+    cy.getBySel('sort-header').eq(7).contains('Active');
     // TODO Cypress won't recognize the Actions column
     // cy.getBySel('sort-header').eq(9).contains('Actions');
   });

superset-frontend/cypress-base/cypress/e2e/alerts_and_reports/reports.test.ts

@@ -29,10 +29,9 @@ describe('Report list view', () => {
     cy.getBySel('sort-header').eq(2).contains('Name');
     cy.getBySel('sort-header').eq(3).contains('Schedule');
     cy.getBySel('sort-header').eq(4).contains('Notification method');
-    cy.getBySel('sort-header').eq(5).contains('Created by');
-    cy.getBySel('sort-header').eq(6).contains('Owners');
-    cy.getBySel('sort-header').eq(7).contains('Modified');
-    cy.getBySel('sort-header').eq(8).contains('Active');
+    cy.getBySel('sort-header').eq(5).contains('Owners');
+    cy.getBySel('sort-header').eq(6).contains('Last modified');
+    cy.getBySel('sort-header').eq(7).contains('Active');
     // TODO Cypress won't recognize the Actions column
     // cy.getBySel('sort-header').eq(9).contains('Actions');
   });

superset-frontend/cypress-base/cypress/e2e/chart_list/filter.test.ts

@@ -35,14 +35,14 @@ describe('Charts filters', () => {
     setFilter('Owner', 'admin user');
   });
 
-  it('should allow filtering by "Created by" correctly', () => {
-    setFilter('Created by', 'alpha user');
-    setFilter('Created by', 'admin user');
+  it('should allow filtering by "Modified by" correctly', () => {
+    setFilter('Modified by', 'alpha user');
+    setFilter('Modified by', 'admin user');
   });
 
-  it('should allow filtering by "Chart type" correctly', () => {
-    setFilter('Chart type', 'Area Chart (legacy)');
-    setFilter('Chart type', 'Bubble Chart');
+  it('should allow filtering by "Type" correctly', () => {
+    setFilter('Type', 'Area Chart (legacy)');
+    setFilter('Type', 'Bubble Chart');
   });
 
   it('should allow filtering by "Dataset" correctly', () => {
@@ -51,7 +51,7 @@ describe('Charts filters', () => {
   });
 
   it('should allow filtering by "Dashboards" correctly', () => {
-    setFilter('Dashboards', 'Unicode Test');
-    setFilter('Dashboards', 'Tabbed Dashboard');
+    setFilter('Dashboard', 'Unicode Test');
+    setFilter('Dashboard', 'Tabbed Dashboard');
   });
 });

superset-frontend/cypress-base/cypress/e2e/chart_list/list.test.ts

@@ -109,14 +109,12 @@ describe('Charts list', () => {
 
     it('should load rows in list mode', () => {
       cy.getBySel('listview-table').should('be.visible');
-      cy.getBySel('sort-header').eq(1).contains('Chart');
-      cy.getBySel('sort-header').eq(2).contains('Visualization type');
+      cy.getBySel('sort-header').eq(1).contains('Name');
+      cy.getBySel('sort-header').eq(2).contains('Type');
       cy.getBySel('sort-header').eq(3).contains('Dataset');
-      // cy.getBySel('sort-header').eq(4).contains('Dashboards added to');
-      cy.getBySel('sort-header').eq(4).contains('Modified by');
+      cy.getBySel('sort-header').eq(4).contains('Owners');
       cy.getBySel('sort-header').eq(5).contains('Last modified');
-      cy.getBySel('sort-header').eq(6).contains('Created by');
-      cy.getBySel('sort-header').eq(7).contains('Actions');
+      cy.getBySel('sort-header').eq(6).contains('Actions');
     });
 
     it('should sort correctly in list mode', () => {

superset-frontend/cypress-base/cypress/e2e/dashboard_list/filter.test.ts

@@ -35,9 +35,9 @@ describe('Dashboards filters', () => {
     setFilter('Owner', 'admin user');
   });
 
-  it('should allow filtering by "Created by" correctly', () => {
-    setFilter('Created by', 'alpha user');
-    setFilter('Created by', 'admin user');
+  it('should allow filtering by "Modified by" correctly', () => {
+    setFilter('Modified by', 'alpha user');
+    setFilter('Modified by', 'admin user');
   });
 
   it('should allow filtering by "Status" correctly', () => {

superset-frontend/cypress-base/cypress/e2e/dashboard_list/list.test.ts

@@ -54,13 +54,11 @@ describe('Dashboards list', () => {
 
     it('should load rows in list mode', () => {
       cy.getBySel('listview-table').should('be.visible');
-      cy.getBySel('sort-header').eq(1).contains('Title');
-      cy.getBySel('sort-header').eq(2).contains('Modified by');
-      cy.getBySel('sort-header').eq(3).contains('Status');
-      cy.getBySel('sort-header').eq(4).contains('Modified');
-      cy.getBySel('sort-header').eq(5).contains('Created by');
-      cy.getBySel('sort-header').eq(6).contains('Owners');
-      cy.getBySel('sort-header').eq(7).contains('Actions');
+      cy.getBySel('sort-header').eq(1).contains('Name');
+      cy.getBySel('sort-header').eq(2).contains('Status');
+      cy.getBySel('sort-header').eq(3).contains('Owners');
+      cy.getBySel('sort-header').eq(4).contains('Last modified');
+      cy.getBySel('sort-header').eq(5).contains('Actions');
     });
 
     it('should sort correctly in list mode', () => {

superset-frontend/src/components/AuditInfo/AuditInfo.test.tsx

@@ -0,0 +1,64 @@
+import React from 'react';
+import { render, screen, waitFor } from '@testing-library/react';
+import '@testing-library/jest-dom';
+import userEvent from '@testing-library/user-event';
+
+import { supersetTheme, ThemeProvider } from '@superset-ui/core';
+import { AuditInfo, AuditInfoProps, AuditInfoType } from '.';
+
+const TEST_DATE = '2023-11-20';
+const USER = {
+  id: 1,
+  first_name: 'Foo',
+  last_name: 'Bar',
+};
+
+const Wrapper: React.FC<AuditInfoProps> = ({ type, user, date }) => (
+  <ThemeProvider theme={supersetTheme}>
+    <AuditInfo type={type} user={user} date={date} />
+  </ThemeProvider>
+);
+
+test('should render a created tooltip when user is provided', async () => {
+  render(<Wrapper type={AuditInfoType.Created} user={USER} date={TEST_DATE} />);
+
+  const dateElement = screen.getByTestId('audit-info-date');
+  expect(dateElement).toBeInTheDocument();
+  expect(screen.getByText(TEST_DATE)).toBeInTheDocument();
+  userEvent.hover(dateElement);
+  expect(screen.queryByText('Created by: Foo Bar')).not.toBeInTheDocument();
+  const tooltip = await screen.findByRole('tooltip');
+  expect(tooltip).toBeInTheDocument();
+  expect(screen.getByText('Created by: Foo Bar')).toBeInTheDocument();
+});
+
+test('should render a modified tooltip when user is provided', async () => {
+  render(
+    <Wrapper type={AuditInfoType.Modified} user={USER} date={TEST_DATE} />,
+  );
+
+  const dateElement = screen.getByTestId('audit-info-date');
+  expect(dateElement).toBeInTheDocument();
+  expect(screen.getByText(TEST_DATE)).toBeInTheDocument();
+  expect(screen.queryByText('Modified by: Foo Bar')).not.toBeInTheDocument();
+  userEvent.hover(dateElement);
+  const tooltip = await screen.findByRole('tooltip');
+  expect(tooltip).toBeInTheDocument();
+  expect(screen.getByText('Modified by: Foo Bar')).toBeInTheDocument();
+});
+
+test('should render only the date if username is not provided', async () => {
+  render(<Wrapper type={AuditInfoType.Modified} date={TEST_DATE} />);
+
+  const dateElement = screen.getByTestId('audit-info-date');
+  expect(dateElement).toBeInTheDocument();
+  expect(screen.getByText(TEST_DATE)).toBeInTheDocument();
+  userEvent.hover(dateElement);
+  await waitFor(
+    () => {
+      const tooltip = screen.queryByRole('tooltip');
+      expect(tooltip).not.toBeInTheDocument();
+    },
+    { timeout: 1000 },
+  );
+});

superset-frontend/src/components/AuditInfo/index.tsx

@@ -0,0 +1,39 @@
+import React from 'react';
+
+import Owner from 'src/types/Owner';
+import { Tooltip } from 'src/components/Tooltip';
+import getOwnerName from 'src/utils/getOwnerName';
+import { t } from '@superset-ui/core';
+
+export const enum AuditInfoType {
+  Modified = 'Modified',
+  Created = 'Created',
+}
+
+export type AuditInfoProps = {
+  type: AuditInfoType;
+  user?: Owner;
+  date: string;
+};
+
+export const AuditInfo = ({ type, user, date }: AuditInfoProps) => {
+  const dateSpan = (
+    <span className="no-wrap" data-test="audit-info-date">
+      {date}
+    </span>
+  );
+
+  if (user) {
+    const userName = getOwnerName(user);
+    const title =
+      type === AuditInfoType.Created
+        ? t('Created by: %s', userName)
+        : t('Modified by: %s', userName);
+    return (
+      <Tooltip title={title} placement="bottom">
+        {dateSpan}
+      </Tooltip>
+    );
+  }
+  return dateSpan;
+};

superset-frontend/src/components/Datasource/DatasourceEditor.jsx

@@ -1114,7 +1114,7 @@ class DatasourceEditor extends React.PureComponent {
                     <div css={{ width: 'calc(100% - 34px)', marginTop: -16 }}>
                       <Field
                         fieldKey="table_name"
-                        label={t('Dataset name')}
+                        label={t('Name')}
                         control={
                           <TextControl
                             controlId="table_name"

superset-frontend/src/dashboard/components/PropertiesModal/index.tsx

@@ -681,7 +681,7 @@ const PropertiesModal = ({
         </Row>
         <Row gutter={16}>
           <Col xs={24} md={12}>
-            <FormItem label={t('Title')} name="title">
+            <FormItem label={t('Name')} name="title">
               <Input
                 data-test="dashboard-title-input"
                 type="text"

superset-frontend/src/features/annotations/AnnotationModal.tsx

@@ -287,7 +287,7 @@ const AnnotationModal: FunctionComponent<AnnotationModalProps> = ({
       </StyledAnnotationTitle>
       <AnnotationContainer>
         <div className="control-label">
-          {t('Annotation name')}
+          {t('Name')}
           <span className="required">*</span>
         </div>
         <input

superset-frontend/src/features/cssTemplates/CssTemplateModal.tsx

@@ -105,6 +105,9 @@ const CssTemplateModal: FunctionComponent<CssTemplateModalProps> = ({
         const update_id = currentCssTemplate.id;
         delete currentCssTemplate.id;
         delete currentCssTemplate.created_by;
+        delete currentCssTemplate.changed_by;
+        delete currentCssTemplate.changed_on_delta_humanized;
+
         updateResource(update_id, currentCssTemplate).then(response => {
           if (!response) {
             return;
@@ -235,7 +238,7 @@ const CssTemplateModal: FunctionComponent<CssTemplateModalProps> = ({
       </StyledCssTemplateTitle>
       <TemplateContainer>
         <div className="control-label">
-          {t('CSS template name')}
+          {t('Name')}
           <span className="required">*</span>
         </div>
         <input

superset-frontend/src/features/cssTemplates/types.ts

@@ -1,3 +1,5 @@
+import Owner from 'src/types/Owner';
+
 /**
  * Licensed to the Apache Software Foundation (ASF) under one
  * or more contributor license agreements.  See the NOTICE file
@@ -16,17 +18,12 @@
  * specific language governing permissions and limitations
  * under the License.
  */
-type CreatedByUser = {
-  id: number;
-  first_name: string;
-  last_name: string;
-};
-
 export type TemplateObject = {
   id?: number;
   changed_on_delta_humanized?: string;
   created_on?: string;
-  created_by?: CreatedByUser;
+  changed_by?: Owner;
+  created_by?: Owner;
   css?: string;
   template_name: string;
 };

superset-frontend/src/features/tags/TagModal.test.tsx

@@ -56,10 +56,12 @@ test('renders correctly in edit mode', () => {
     changed_on_delta_humanized: '',
     created_on_delta_humanized: '',
     created_by: {
+      id: 1,
       first_name: 'joe',
       last_name: 'smith',
     },
     changed_by: {
+      id: 2,
       first_name: 'tom',
       last_name: 'brown',
     },