Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(databases): Update pinot.mdx to incorporate username and password based connection. #26000

Merged
merged 2 commits into from
Nov 27, 2023

Conversation

raamri
Copy link
Contributor

@raamri raamri commented Nov 16, 2023

SUMMARY

Updating the documentation to incorporate the username and password based sql for connecting to Apache Pinot.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

N/A.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Updating the documentation to incorporate the username and password based sql for connecting to Apache Pinot.
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

@sfirke
Copy link
Member

sfirke commented Nov 16, 2023

Hi and thanks for this! I thought "I know someone shared this in Slack, I'll compare them" -- and then I realized I think that was you 😁

In your Slack config it began simply pinot://, here you have pinot+http -- is that +http needed? And in Slack you ended it &verify_ssl=true instead of a trailing slash.

@sfirke
Copy link
Member

sfirke commented Nov 16, 2023

Looks like linting check failed due to:

Error: Please format your PR title to match: ^(build|chore|ci|docs|feat|fix|perf|refactor|style|test|other)(\(.+\))?(\!)?:\s.+!

Can you change the PR title to begin docs(databases): ?

@sfirke sfirke self-assigned this Nov 16, 2023
@john-bodley john-bodley changed the title Update pinot.mdx to incorporate username and password based connection docs: Update pinot.mdx to incorporate username and password based connection Nov 16, 2023
@raamri raamri changed the title docs: Update pinot.mdx to incorporate username and password based connection docs(databases): Update pinot.mdx to incorporate username and password based connection. Nov 17, 2023
@raamri
Copy link
Contributor Author

raamri commented Nov 17, 2023

Hi @sfirke sfirke! Updated the PR title and the doc based on your suggestions.

  1. verify_ssl=true is actually needed.
  2. +http is not needed. Adding that would also do no harm though. Still, removing it.
    Thanks!

Copy link
Member

@sfirke sfirke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@sfirke sfirke merged commit d20f96f into apache:master Nov 27, 2023
34 checks passed
@sfirke
Copy link
Member

sfirke commented Nov 27, 2023

thanks @raamri !

josedev-union pushed a commit to Ortege-xyz/studio that referenced this pull request Jan 22, 2024
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 3.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants