Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(security): restore default value of SESSION_COOKIE_SECURE to False #26005

Merged
merged 2 commits into from
Nov 21, 2023

Conversation

sfirke
Copy link
Member

@sfirke sfirke commented Nov 16, 2023

SUMMARY

The default value of SESSION_COOKIE_SECURE was historically False. This was changed unintentionally when we enabled TALISMAN_CONFIG by default. That comes with unstated, implicit settings including making SESSION_COOKIE_SECURE = True. This contradicts our documentation (issue #25854).

More importantly, it contributed to a critical problem where new users who have not enabled HTTPS yet as part of their setup encounter a login loop and are unable to use Superset. The canonical issue here is #24579 (comment), please review that thread ending with the comment I linked.

When users discuss this problem in the issues, the two most upvoted "fixes" are to disable Talisman entirely or to revert to Superset 2.1.0 (which did not have Talisman enabled by default) 😬

I'm not an expert in this area and there might be more we need to to do to get a combination of security values that works for out-of-the-box setups. But this PR seemed like a good simple start in that it's reverting an unintended change that came when we implemented Talisman CSP.

TESTING INSTRUCTIONS

Install a new instance of Superset with this config value in Talisman? Two users in that thread report that this config change enabled them to install and use Superset.

ADDITIONAL INFORMATION

@john-bodley john-bodley added review:checkpoint Last PR reviewed during the daily review standup and removed review:checkpoint Last PR reviewed during the daily review standup labels Nov 16, 2023
@sfirke sfirke merged commit bba7763 into apache:master Nov 21, 2023
29 checks passed
@sfirke sfirke deleted the secure_cookie_false branch November 21, 2023 14:11
@michael-s-molina michael-s-molina added the v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch label Nov 21, 2023
michael-s-molina pushed a commit that referenced this pull request Dec 4, 2023
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🍒 3.0.3 🍒 3.0.4 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
sfirke added a commit to sfirke/superset that referenced this pull request Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch 🍒 3.0.3 🍒 3.0.4 🚢 3.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation incorrect: SESSION_COOKIE_SECURE is true by default Login page loops indefinitely
5 participants