fix: Remove annotation Fuzzy to get french translation #26010

aehanno · 2023-11-16T21:29:54Z

Fix this pb : #25728

sfirke · 2023-11-17T15:48:03Z

It looks like all of the other languages have lower case (example), which matches the base set for translation. French has uppercase and it's not matching. Do you agree the French should be changed to lowercase? I worry that this PR would fix French and break all of the other languages.

sfirke

See my comment in the PR conversation, I think the proper fix would be to make the French translation values lower case, not the base ones capitalized.

Add translation from script po2json

aehanno · 2023-11-17T16:00:14Z

Hey @sfirke, yes I just saw that, I saw thaht the problem is the annatation #, fuzzy in po file
Do you know why we have that and is it's correct if I just remove this annotation ?

sfirke · 2023-11-17T16:09:24Z

I'm unfamiliar with translations in general. Sounds like the fuzzy there means, attention needed. What problem is the fuzzy comment causing?

sfirke · 2023-11-17T16:10:03Z

Also thanks for updating the French strings to match the base set, it looks good now.

Fix translation

aehanno · 2023-11-17T16:28:13Z

I'm unfamiliar with translations in general. Sounds like the fuzzy there means, attention needed. What problem is the fuzzy comment causing?

The problem with the fuzzy, it's with this annotation when I launch the script po2json.sh to have my translation. All the string with this annotation are not taken into account.
So they don't appear in the json file
So the translation doesn't appear on the interface either

sfirke · 2023-11-17T16:56:41Z

Ah okay. I don't see "fuzzy" appearing in the codebase anywhere so I'd say go ahead and delete that. If you can test locally that all the desired translations are appearing, that works for me.

sfirke · 2023-11-17T16:59:43Z

superset/translations/fr/LC_MESSAGES/messages.json

@@ -4591,18 +4618,10 @@
      "y: values are normalized within each row": [""],
      "year": ["année"],
      "zoom area": [""],
-      "No matching records found": ["Aucun résultat trouvé"],


Did you replace this string? I see it deleted here but no other mention of "no matching records found"

Just annotation fuzzy on this string, I remove it

I don't follow, sorry. Will the string "No matching records found" still be translated?

Fix translation

sfirke

LGTM

sfirke · 2023-11-17T18:52:56Z

This is my first time working with translations - anyone who has more experience want to review + merge?

Fix translation

codecov · 2023-11-17T21:11:51Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5942d8b) 66.90% compared to head (ed2affd) 69.06%.
Report is 8 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #26010      +/-   ##
==========================================
+ Coverage   66.90%   69.06%   +2.16%     
==========================================
  Files        1938     1938              
  Lines       75837    75858      +21     
  Branches     8427     8427              
==========================================
+ Hits        50736    52389    +1653     
+ Misses      22931    21299    -1632     
  Partials     2170     2170

Flag	Coverage Δ
hive	`53.66% <ø> (?)`
mysql	`78.16% <ø> (-0.04%)`	⬇️
postgres	`78.26% <ø> (-0.04%)`	⬇️
presto	`53.61% <ø> (?)`
python	`82.91% <ø> (+4.48%)`	⬆️
sqlite	`76.91% <ø> (-0.04%)`	⬇️
unit	`55.73% <ø> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

aehanno · 2023-11-20T15:52:59Z

@sfirke, Hey thanks for the review.
Do you know if it can be merge in the 3.0.2 release
It will be so great

sfirke

Did you mean to translate "JSON" to "YAML"?

superset/translations/fr/LC_MESSAGES/messages.json

superset/translations/fr/LC_MESSAGES/messages.po

sfirke · 2023-11-20T17:42:03Z

superset/translations/fr/LC_MESSAGES/messages.json

@@ -4591,18 +4618,10 @@
      "y: values are normalized within each row": [""],
      "year": ["année"],
      "zoom area": [""],
-      "No matching records found": ["Aucun résultat trouvé"],


I don't follow, sorry. Will the string "No matching records found" still be translated?

aehanno · 2023-11-20T19:17:50Z

for the quesiton : #26010 (comment)

The translation is present line 2254

Correction translation

sfirke

Merci pour les améliorations! (Looks good to me 😜)

rusackas

LGTM!

(cherry picked from commit 25a737e)

Without the capital letter, you can't find the translation

570a6f7

pull-request-size bot added the size/S label Nov 16, 2023

aehanno changed the title ~~Without the capital letter, you can't find the translation~~ fix: Without the capital letter, you can't find the translation Nov 16, 2023

aehanno mentioned this pull request Nov 16, 2023

Translation: missing terms in french #25728

Closed

3 tasks

Correction test

819f427

aehanno requested review from jinghua-qa, geido, eschutho, rusackas and betodealmeida as code owners November 16, 2023 22:23

sfirke requested changes Nov 17, 2023

View reviewed changes

Correction test

d9e8b1f

Add translation from script po2json

pull-request-size bot added size/M and removed size/S labels Nov 17, 2023

Correction test

f8cf99a

Fix translation

sfirke approved these changes Nov 17, 2023

View reviewed changes

Correction test

b81a72f

Fix translation

sfirke approved these changes Nov 17, 2023

View reviewed changes

Correction test

a33b9f2

Fix translation

pull-request-size bot added size/L and removed size/M labels Nov 17, 2023

aehanno changed the title ~~fix: Without the capital letter, you can't find the translation~~ fix: Remove annotation Fuzzy to get french translation Nov 17, 2023

aehanno added 2 commits November 17, 2023 16:49

Merge branch 'master' into missing_tranduction_time_period

0ec6e81

Correction translation

ec6fb6c

sfirke requested changes Nov 20, 2023

View reviewed changes

Correction translation

ed2affd

Correction translation

sfirke approved these changes Nov 20, 2023

View reviewed changes

sfirke added the merge-if-green If approved and tests are green, please go ahead and merge it for me label Nov 20, 2023

rusackas approved these changes Nov 21, 2023

View reviewed changes

rusackas merged commit 25a737e into apache:master Nov 21, 2023
33 checks passed

michael-s-molina added the v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch label Nov 21, 2023

Ralkion mentioned this pull request Nov 22, 2023

fix: Translations related to the date range filter #26074

Merged

10 tasks

michael-s-molina pushed a commit that referenced this pull request Dec 4, 2023

fix: Remove annotation Fuzzy to get french translation (#26010)

79d8865

(cherry picked from commit 25a737e)

josedev-union pushed a commit to Ortege-xyz/studio that referenced this pull request Jan 22, 2024

fix: Remove annotation Fuzzy to get french translation (apache#26010)

556cebb

cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024

fix: Remove annotation Fuzzy to get french translation (apache#26010)

2bb500a

mistercrunch added 🍒 3.0.3 🍒 3.0.4 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024

sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024

fix: Remove annotation Fuzzy to get french translation (apache#26010)

10fa468

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Remove annotation Fuzzy to get french translation #26010

fix: Remove annotation Fuzzy to get french translation #26010

aehanno commented Nov 16, 2023

sfirke commented Nov 17, 2023

sfirke left a comment

aehanno commented Nov 17, 2023

sfirke commented Nov 17, 2023

sfirke commented Nov 17, 2023

aehanno commented Nov 17, 2023

sfirke commented Nov 17, 2023

sfirke Nov 17, 2023

aehanno Nov 17, 2023

sfirke Nov 20, 2023

sfirke left a comment

sfirke commented Nov 17, 2023

codecov bot commented Nov 17, 2023 •

edited

Loading

aehanno commented Nov 20, 2023

sfirke left a comment

sfirke Nov 20, 2023

aehanno commented Nov 20, 2023

sfirke left a comment

rusackas left a comment

fix: Remove annotation Fuzzy to get french translation #26010

fix: Remove annotation Fuzzy to get french translation #26010

Conversation

aehanno commented Nov 16, 2023

sfirke commented Nov 17, 2023

sfirke left a comment

Choose a reason for hiding this comment

aehanno commented Nov 17, 2023

sfirke commented Nov 17, 2023

sfirke commented Nov 17, 2023

aehanno commented Nov 17, 2023

sfirke commented Nov 17, 2023

sfirke Nov 17, 2023

Choose a reason for hiding this comment

aehanno Nov 17, 2023

Choose a reason for hiding this comment

sfirke Nov 20, 2023

Choose a reason for hiding this comment

sfirke left a comment

Choose a reason for hiding this comment

sfirke commented Nov 17, 2023

codecov bot commented Nov 17, 2023 • edited Loading

Codecov Report

aehanno commented Nov 20, 2023

sfirke left a comment

Choose a reason for hiding this comment

sfirke Nov 20, 2023

Choose a reason for hiding this comment

aehanno commented Nov 20, 2023

sfirke left a comment

Choose a reason for hiding this comment

rusackas left a comment

Choose a reason for hiding this comment

codecov bot commented Nov 17, 2023 •

edited

Loading