Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(BH#109): Athena URI spec fix #26044

Merged
merged 2 commits into from
Nov 21, 2023
Merged

docs(BH#109): Athena URI spec fix #26044

merged 2 commits into from
Nov 21, 2023

Conversation

rusackas
Copy link
Member

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Someone reported the Athena driver being broken/cut off. I found the missing bits on Stack Overflow and I'm posting them here. Hopefully this is correct, but we would need an Athena user to test (there are none on the rolodex

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@rusackas rusackas requested a review from sfirke November 21, 2023 00:11
@rusackas rusackas marked this pull request as ready for review November 21, 2023 00:11
Copy link

codecov bot commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e7797b6) 69.08% compared to head (05e8011) 69.07%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #26044      +/-   ##
==========================================
- Coverage   69.08%   69.07%   -0.02%     
==========================================
  Files        1941     1941              
  Lines       75892    75892              
  Branches     8443     8443              
==========================================
- Hits        52431    52420      -11     
- Misses      21286    21297      +11     
  Partials     2175     2175              
Flag Coverage Δ
hive 53.66% <ø> (ø)
javascript 56.27% <ø> (ø)
mysql ?
postgres 78.26% <ø> (ø)
presto 53.61% <ø> (ø)
python 82.88% <ø> (-0.04%) ⬇️
sqlite 76.91% <ø> (ø)
unit 55.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - confirmed that this is the connection string Google gives + the one we have in the dedicated Athena section.

@sfirke sfirke merged commit 1af5fbb into master Nov 21, 2023
73 checks passed
@sfirke sfirke deleted the athena-doc-fix branch November 21, 2023 14:12
@rusackas rusackas restored the athena-doc-fix branch November 21, 2023 16:50
@rusackas rusackas deleted the athena-doc-fix branch November 21, 2023 16:51
josedev-union pushed a commit to Ortege-xyz/studio that referenced this pull request Jan 22, 2024
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 3.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants