fix: Flaky test_explore_json_async test #26059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #26059 +/- ##
==========================================
+ Coverage 69.08% 69.10% +0.01%
==========================================
Files 1941 1940 -1
Lines 75882 75869 -13
Branches 8443 8443
==========================================
+ Hits 52423 52426 +3
+ Misses 21284 21268 -16
Partials 2175 2175
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
john-bodley
reviewed
Nov 21, 2023
john-bodley
approved these changes
Nov 21, 2023
Co-authored-by: John Bodley <4567245+john-bodley@users.noreply.github.com>
michael-s-molina
added
the
v3.0
9 tasks
michael-s-molina
added a commit
that referenced
this pull request
Dec 4, 2023
Co-authored-by: John Bodley <4567245+john-bodley@users.noreply.github.com> (cherry picked from commit 2b88225)
josedev-union
pushed a commit
to Ortege-xyz/studio
that referenced
this pull request
Jan 22, 2024
Co-authored-by: John Bodley <4567245+john-bodley@users.noreply.github.com>
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
Co-authored-by: John Bodley <4567245+john-bodley@users.noreply.github.com>
mistercrunch
added
🍒 3.0.3
🍒 3.0.4
🏷️ bot
sfirke
pushed a commit
to sfirke/superset
that referenced
this pull request
Mar 22, 2024
Co-authored-by: John Bodley <4567245+john-bodley@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR fixes the following flaky CI error:
The problem is that the response status will vary if the results are cached which depends on the tests execution order. Given that both
200and202are valid response status for this endpoint, I updated the test to reflect that.TESTING INSTRUCTIONS
CI should be sufficient.
ADDITIONAL INFORMATION