Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(storybook): fix typo in TimeFormatStories.tsx #26105

Merged
merged 3 commits into from
Jan 23, 2024
Merged

docs(storybook): fix typo in TimeFormatStories.tsx #26105

merged 3 commits into from
Jan 23, 2024

Conversation

HurSungYun
Copy link
Contributor

@HurSungYun HurSungYun commented Nov 27, 2023 •
edited
Loading

SUMMARY

This Pull Request fixes a typographical error in https://apache-superset.github.io/superset-ui/?path=/story/core-packages-superset-ui-time-format--validator

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Current screenshot is below.

스크린샷 2023-11-27 오후 11 25 49

TESTING INSTRUCTIONS

Skipped.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@HurSungYun HurSungYun changed the title docs(storybook): fix typo docs(storybook): fix typo in TimeFormatStories.tsx Nov 27, 2023
@john-bodley john-bodley added the review:checkpoint Last PR reviewed during the daily review standup label Nov 28, 2023
@HurSungYun
Copy link
Contributor Author

@john-bodley thank you for the review. I've fixed lint errors. Can you please run CI once again?

@john-bodley john-bodley removed the review:checkpoint Last PR reviewed during the daily review standup label Nov 30, 2023
@rusackas rusackas merged commit d8d0c9c into apache:master Jan 23, 2024
26 checks passed
rusackas pushed a commit that referenced this pull request Jan 24, 2024
@HurSungYun @rusackas
docs(storybook): fix typo in TimeFormatStories.tsx (#26105)
2c30e92
eschutho pushed a commit to preset-io/superset that referenced this pull request Jan 31, 2024
@HurSungYun @eschutho
docs(storybook): fix typo in TimeFormatStories.tsx (apache#26105)
07f26f6
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
@HurSungYun @sfirke
docs(storybook): fix typo in TimeFormatStories.tsx (apache#26105)
730abf0
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.0.0 labels Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rusackas rusackas rusackas approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 4.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@HurSungYun @rusackas @mistercrunch @john-bodley