Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update Trino Kerberos configuration #26119

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

john-bodley
Copy link
Member

SUMMARY

This PR serves as a replacement to #26077 by updating the Trino documentation to include instructions on how to install the python-trino-client to include the Kerberos dependencies.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

CI.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link

codecov bot commented Nov 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9a13ec6) 69.10% compared to head (b3b32c3) 69.10%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #26119   +/-   ##
=======================================
  Coverage   69.10%   69.10%           
=======================================
  Files        1940     1940           
  Lines       75869    75869           
  Branches     8445     8445           
=======================================
  Hits        52427    52427           
  Misses      21267    21267           
  Partials     2175     2175           
Flag Coverage Δ
hive 53.68% <ø> (ø)
javascript 56.28% <ø> (ø)
mysql 78.16% <ø> (ø)
postgres 78.25% <ø> (ø)
presto 53.63% <ø> (ø)
python 82.95% <ø> (ø)
sqlite 76.91% <ø> (ø)
unit 55.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfirke sfirke merged commit 0d2e855 into master Nov 28, 2023
53 checks passed
@sfirke sfirke deleted the john-bodley--docs-trino-kerberos branch November 28, 2023 20:10
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.0.0 labels Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 4.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants