feat: Adds legacy time support for Waterfall chart

[michael-s-molina]

SUMMARY

Follow-up of #25557 to add support for legacy time controls in Waterfall charts.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

1 - Set GENERIC_CHART_AXES feature flag to False
2 - Test if you are able to create a Waterfall chart using the legacy time controls

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (b9aaf0f) 58.93% compared to head (e2cdce7) 58.92%.
Report is 4 commits behind head on master.

Files	Patch %	Lines
...lugin-chart-echarts/src/Waterfall/controlPanel.tsx	0.00%	0 Missing and 2 partials ⚠️
...ugin-chart-echarts/src/Waterfall/transformProps.ts	33.33%	0 Missing and 2 partials ⚠️
...s/plugin-chart-echarts/src/Waterfall/buildQuery.ts	50.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #26136      +/-   ##
==========================================
- Coverage   58.93%   58.92%   -0.02%     
==========================================
  Files        1941     1941              
  Lines       75873    75888      +15     
  Branches     8447     8454       +7     
==========================================
  Hits        44714    44714              
- Misses      28984    28996      +12     
- Partials     2175     2178       +3     

Flag	Coverage Δ
javascript	56.26% <28.57%> (-0.03%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[justinpark]

Doesn't a row value of null result in an empty DOM placeholder?
How about conditionally appending generic x-axis control?

Suggested change

	[hasGenericChartAxes ? 'x_axis' : null],
	...(hasGenericChartAxes ? ['x_axis', 'time_grain_sqla'] : []),

[michael-s-molina]

Doesn't a row value of null result in an empty DOM placeholder?

It does not. This pattern is used everywhere.

How about conditionally appending generic x-axis control?

We need to add the x_axis and time_grain_sqla into different arrays.

[villebro]

@michael-s-molina a general observation about this change - as we've already enabled GENERIC_CHART_AXES by default, do we really want to support non-generic mode in new viz types? This adds maintenance burden, and makes the task of deprecating those legacy controls even bigger. As an alternative, maybe we could just disable this chart type if generic chart axes is disabled?

[justinpark]

LGTM upon @villebro 's approval

[michael-s-molina]

@michael-s-molina a general observation about this change - as we've already enabled GENERIC_CHART_AXES by default, do we really want to support non-generic mode in new viz types? This adds maintenance burden, and makes the task of deprecating those legacy controls even bigger. As an alternative, maybe we could just disable this chart type if generic chart axes is disabled?

@villebro You're correct. I think there's no obligation to support non-generic mode in new viz types. I just did it for this chart because we want it at Airbnb but we didn't enable GENERIC_CHART_AXES yet. Luckily, 4.0 is coming (March 2024) to delete the legacy code and resolve our problems. We'll enable that feature flag by then.