fix: set label on adhoc column should persist

[betodealmeida]

SUMMARY

The component for defining columns has an unorthodox architecture:

 ____________________________________
|                                    |
| <DndColumnSelect />                |
|  ________________________________  |
| |                                | |
| | <ColumnSelectPopoverTrigger /> | |
| |                                | |
| | genre (pencil)                 | |
| |________________________________| |
|  ________________________________  |
| |                                | |
| | <ColumnSelectPopover />        | |
| |                                | |
| | Saved | Simple | Custom SQL    | |
| |                                | |
| | genre                          | |
| |                                | |
| | [    CLOSE    ] [    SAVE    ] | |
| |________________________________| |
|____________________________________|

When a user edits the label using the pencil in <ColumnSelectPopoverTrigger />, the <ColumnSelectPopover /> component is not aware of that change. If the users then clicks "SAVE" to use the adhoc column ("CUSTOM SQL") with the new label, the <ColumnSelectPopover /> won't do anything because it's not aware of any changes.

This PR modifies <ColumnSelectPopover /> so that if the user selects "CUSTOM SQL" and the label has been modified (via a new prop hasCustomLabel), then an adhoc column is defined in the component's state. This way, when "SAVE" is clicked, the label gets persisted correctly.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (cff473f) 69.13% compared to head (3f56815) 69.20%.
Report is 2 commits behind head on master.

Files	Patch %	Lines
...ColumnSelectControl/ColumnSelectPopoverTrigger.tsx	33.33%	2 Missing ⚠️
...ols/DndColumnSelectControl/ColumnSelectPopover.tsx	87.50%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #26154      +/-   ##
==========================================
+ Coverage   69.13%   69.20%   +0.07%     
==========================================
  Files        1941     1941              
  Lines       75893    75901       +8     
  Branches     8450     8453       +3     
==========================================
+ Hits        52466    52531      +65     
+ Misses      21252    21177      -75     
- Partials     2175     2193      +18     

Flag	Coverage Δ
hive	53.68% <ø> (ø)
javascript	56.49% <72.72%> (+0.15%)	⬆️
mysql	78.16% <ø> (ø)
postgres	78.26% <ø> (ø)
presto	53.63% <ø> (ø)
python	82.95% <ø> (ø)
sqlite	76.91% <ø> (ø)
unit	55.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[eschutho]

/testenv up

[github-actions]

@eschutho Ephemeral environment spinning up at http://18.237.178.227:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[github-actions]

Ephemeral environment shutdown and build artifacts deleted.