Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(init-job): Fix envFrom for init job in helm chart #26157

Merged
merged 3 commits into from
Dec 6, 2023
Merged

fix(init-job): Fix envFrom for init job in helm chart #26157

merged 3 commits into from
Dec 6, 2023

Conversation

sumagoudb
Copy link
Contributor

It breaks when I use envFromSecrets in helm value as the quotes are missing for the init job.

@sumagoudb
Fix envFrom for init job
2dd2a61 
It breaks when I use envFromSecrets in helm value as the quotes are missing for the init job.
github-actions[bot]
github-actions bot reviewed Dec 1, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

dpgaspar
dpgaspar reviewed Dec 5, 2023
View reviewed changes
Copy link
Member

@dpgaspar dpgaspar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
LGTM, you have to bump the chart version also

@sumagoudb
Copy link
Contributor Author

Thank you! LGTM, you have to bump the chart version also

Done, can you merge?

@craig-rueda craig-rueda merged commit 4d4b19e into apache:master Dec 6, 2023
26 checks passed
@sumagoudb sumagoudb deleted the patch-1 branch December 6, 2023 17:56
@michael-s-molina michael-s-molina added v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch v3.1 Label added by the release manager to track PRs to be included in the 3.1 branch labels Dec 8, 2023
michael-s-molina pushed a commit that referenced this pull request Dec 8, 2023
@sumagoudb @michael-s-molina
fix(init-job): Fix envFrom for init job in helm chart (#26157)
03abfba
michael-s-molina pushed a commit that referenced this pull request Dec 8, 2023
@sumagoudb @michael-s-molina
fix(init-job): Fix envFrom for init job in helm chart (#26157)
2104a9a 
(cherry picked from commit 4d4b19e)
josedev-union pushed a commit to Ortege-xyz/studio that referenced this pull request Jan 22, 2024
@sumagoudb @josedev-union
fix(init-job): Fix envFrom for init job in helm chart (apache#26157)
c6d2ce3 
(cherry picked from commit 4d4b19e)
@mistercrunch mistercrunch added 🍒 3.0.3 🍒 3.0.4 🍒 3.1.0 🍒 3.1.1 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels labels Mar 8, 2024
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
@sumagoudb @sfirke
fix(init-job): Fix envFrom for init job in helm chart (apache#26157)
d73ab17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@craig-rueda craig-rueda craig-rueda left review comments

@github-actions github-actions[bot] github-actions left review comments

@dpgaspar dpgaspar dpgaspar approved these changes

@villebro villebro Awaiting requested review from villebro villebro is a code owner

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch v3.1 Label added by the release manager to track PRs to be included in the 3.1 branch 🍒 3.0.3 🍒 3.0.4 🍒 3.1.0 🍒 3.1.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sumagoudb @craig-rueda @dpgaspar @mistercrunch @michael-s-molina