feat: Create db_engine_spec ibmi.py

[wAVeckx]

SUMMARY

Similar to db2, but needed for ibmi with some adjustments. This will work with sqlalchemy-ibmi.

TESTING INSTRUCTIONS

Test with SQL Lab with an IBM i database. Without this change it will fail with using LIMIT.

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (b2ea97a) 69.13% compared to head (fad8761) 66.90%.
Report is 10 commits behind head on master.

Files	Patch %	Lines
superset/db_engine_specs/ibmi.py	87.50%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #26161      +/-   ##
==========================================
- Coverage   69.13%   66.90%   -2.23%     
==========================================
  Files        1941     1942       +1     
  Lines       75895    75908      +13     
  Branches     8454     8454              
==========================================
- Hits        52468    50790    -1678     
- Misses      21249    22940    +1691     
  Partials     2178     2178              

Flag	Coverage Δ
hive	?
mysql	78.09% <87.50%> (-0.05%)	⬇️
postgres	78.18% <87.50%> (-0.08%)	⬇️
presto	?
python	78.32% <87.50%> (-4.63%)	⬇️
sqlite	76.84% <87.50%> (-0.08%)	⬇️
unit	?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[villebro]

Comment about DRYing up the code. Also, it would be great if you could add a few simple unit tests for this. You can take a look at tests/unit_tests/db_engine_specs.

[wAVeckx]

Not sure on the pre-commit failure.

[villebro]

@wAVeckx you're missing a newline before the class declaration:

[villebro]

LGTM