Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sqllab): migrate to typescript #26171

Merged

Conversation

justinpark
Copy link
Member

SUMMARY

This commit migrates legacy jsx and tests to typescript

TESTING INSTRUCTIONS

npm run type and test

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (2cd7135) 67.17% compared to head (81f7470) 67.16%.

Files Patch % Lines
...d/src/SqlLab/components/TabbedSqlEditors/index.tsx 69.23% 1 Missing and 3 partials ⚠️
...d/src/SqlLab/components/SqlEditorLeftBar/index.tsx 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #26171      +/-   ##
==========================================
- Coverage   67.17%   67.16%   -0.01%     
==========================================
  Files        1899     1899              
  Lines       74354    74357       +3     
  Branches     8266     8275       +9     
==========================================
  Hits        49945    49945              
- Misses      22360    22361       +1     
- Partials     2049     2051       +2     
Flag Coverage Δ
javascript 56.91% <73.68%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rusackas
Copy link
Member

Looking good to me so far... but boy, it's a lot to chew on, so I'll re-review before approving.

Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had our AI overlords take a second look at the diff and try to spot risks, and it wasn't able to find anything that seemed worrisome.

@justinpark justinpark force-pushed the chore--sqllab-migrate-to-typescript branch from 10babe3 to 848afdc Compare January 24, 2024 00:46
@justinpark justinpark force-pushed the chore--sqllab-migrate-to-typescript branch from 848afdc to 81f7470 Compare February 5, 2024 22:34
@rusackas rusackas merged commit 14f88e3 into apache:master Feb 6, 2024
33 checks passed
@rusackas
Copy link
Member

rusackas commented Feb 6, 2024

@justinpark I just went for the merge button when I saw it since it looks like it was rebased twice already ;)

sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.0.0 labels Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XL 🚢 4.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants