-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(sqllab): migrate to typescript #26171
chore(sqllab): migrate to typescript #26171
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #26171 +/- ##
==========================================
- Coverage 67.17% 67.16% -0.01%
==========================================
Files 1899 1899
Lines 74354 74357 +3
Branches 8266 8275 +9
==========================================
Hits 49945 49945
- Misses 22360 22361 +1
- Partials 2049 2051 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Looking good to me so far... but boy, it's a lot to chew on, so I'll re-review before approving. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had our AI overlords take a second look at the diff and try to spot risks, and it wasn't able to find anything that seemed worrisome.
10babe3
to
848afdc
Compare
848afdc
to
81f7470
Compare
@justinpark I just went for the merge button when I saw it since it looks like it was rebased twice already ;) |
SUMMARY
This commit migrates legacy jsx and tests to typescript
TESTING INSTRUCTIONS
npm run type and test
ADDITIONAL INFORMATION