Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Adds note about numerical x-axis #26208

Merged

Conversation

michael-s-molina
Copy link
Member

SUMMARY

26034 fixed a problem where numeric x-axis were being treated as categorical values. As a consequence of that, the way labels are displayed might change given that ECharts has a different treatment for numerical and categorical values. This PR adds a note to UPDATING.md explaining the changes to users and guiding them on how to restore the previous behavior.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

UPDATING.md Outdated Show resolved Hide resolved
Co-authored-by: John Bodley <4567245+john-bodley@users.noreply.github.com>
@john-bodley john-bodley merged commit b4a35e6 into apache:master Dec 7, 2023
26 checks passed
@john-bodley john-bodley added the review:checkpoint Last PR reviewed during the daily review standup label Dec 7, 2023
@michael-s-molina michael-s-molina added v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch v3.1 Label added by the release manager to track PRs to be included in the 3.1 branch labels Dec 8, 2023
michael-s-molina added a commit that referenced this pull request Dec 8, 2023
Co-authored-by: John Bodley <4567245+john-bodley@users.noreply.github.com>
michael-s-molina added a commit that referenced this pull request Dec 8, 2023
Co-authored-by: John Bodley <4567245+john-bodley@users.noreply.github.com>
(cherry picked from commit b4a35e6)
@john-bodley john-bodley removed the review:checkpoint Last PR reviewed during the daily review standup label Dec 8, 2023
josedev-union pushed a commit to Ortege-xyz/studio that referenced this pull request Jan 22, 2024
Co-authored-by: John Bodley <4567245+john-bodley@users.noreply.github.com>
(cherry picked from commit b4a35e6)
@mistercrunch mistercrunch added 🍒 3.0.3 🍒 3.0.4 🍒 3.1.0 🍒 3.1.1 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels labels Mar 8, 2024
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
Co-authored-by: John Bodley <4567245+john-bodley@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch v3.1 Label added by the release manager to track PRs to be included in the 3.1 branch 🍒 3.0.3 🍒 3.0.4 🍒 3.1.0 🍒 3.1.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants