Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dashboard): migrate enzyme to RTL #26260

Conversation

justinpark
Copy link
Member

SUMMARY

This commit migrates enzyme testing codes by react testing-library for src/dashboard

TESTING INSTRUCTIONS

npm run test

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2cd7135) 67.17% compared to head (1b5c36c) 67.16%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #26260      +/-   ##
==========================================
- Coverage   67.17%   67.16%   -0.01%     
==========================================
  Files        1899     1899              
  Lines       74354    74354              
  Branches     8266     8266              
==========================================
- Hits        49945    49939       -6     
- Misses      22360    22362       +2     
- Partials     2049     2053       +4     
Flag Coverage Δ
javascript 56.90% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (and LGTGPT)

@justinpark justinpark force-pushed the chore--migrate-enzyme-test-codes-for-dashboard branch from 56f0bbe to 32fd38d Compare February 5, 2024 22:14
@justinpark justinpark merged commit f8c75ca into apache:master Feb 7, 2024
33 checks passed
@justinpark justinpark deleted the chore--migrate-enzyme-test-codes-for-dashboard branch February 7, 2024 17:17
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.0.0 labels Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XXL 🚢 4.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants