fix(plugin-chart-echarts): use scale for truncating x-axis

[villebro]

SUMMARY

Following up on #26215 by playing whack-a-mole on the numerical x-axis truncation problem. Move from using dataMin/dataMax to scale: true when truncating x-axis for bar charts. This applies automatic truncation by ECharts, which is able to handle truncation more gracefully. For other than bar charts, we'll retain the dataMin/dataMax logic without the scale parameter.

AFTER

Now there is a proper margin on the x-axis to not overlap y-axis.

Now also mixed series chart has the same functionality:

BEFORE

Previously the smallest and largest bars would

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

• [c] Has associated issue: fixes Bar chart spilling out past x-axis on both ends #26254
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[michael-s-molina]

You need to pass seriesType from transformProps.

[codecov]

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (578a899) 69.18% compared to head (4aca8ed) 69.18%.
Report is 2 commits behind head on master.

Files	Patch %	Lines
...hart-echarts/src/MixedTimeseries/transformProps.ts	0.00%	5 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##           master   #26269   +/-   ##
=======================================
  Coverage   69.18%   69.18%           
=======================================
  Files        1945     1945           
  Lines       75948    75961   +13     
  Branches     8460     8465    +5     
=======================================
+ Hits        52545    52556   +11     
- Misses      21218    21220    +2     
  Partials     2185     2185           

Flag	Coverage Δ
javascript	56.52% <72.22%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[villebro]

You need to pass seriesType from transformProps.

Thanks for catching, too many iterations on how to implement this caused the final commit to miss this change..

[villebro]

/testenv up

[github-actions]

@villebro Ephemeral environment spinning up at http://52.13.180.29:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[michael-s-molina]

You also need to adjust the mixed timeseries chart 🙂

[villebro]

You also need to adjust the mixed timeseries chart 🙂

😬

[villebro]

/testenv up

[github-actions]

@villebro Ephemeral environment spinning up at http://35.161.50.28:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[michael-s-molina]

LGTM

[github-actions]

Ephemeral environment shutdown and build artifacts deleted.