Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(explore): migrate enzyme to RTL #26272

Conversation

justinpark
Copy link
Member

SUMMARY

This commit migrates enzyme testing codes by react testing-library for src/explore/components

TESTING INSTRUCTIONS

npm run test

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link

codecov bot commented Dec 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (578a899) 69.18% compared to head (916aeb1) 69.23%.
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #26272      +/-   ##
==========================================
+ Coverage   69.18%   69.23%   +0.04%     
==========================================
  Files        1945     1946       +1     
  Lines       75948    75968      +20     
  Branches     8460     8469       +9     
==========================================
+ Hits        52545    52595      +50     
+ Misses      21218    21183      -35     
- Partials     2185     2190       +5     
Flag Coverage Δ
javascript 56.61% <ø> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justinpark justinpark merged commit 5584699 into apache:master Jan 30, 2024
30 checks passed
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.0.0 labels Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 4.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants