Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(in the wild): Making it even easer to add a name (and cleanup) #26280

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

rusackas
Copy link
Member

SUMMARY

Giving people a direct link to contribute to this file... and doing a little sweeping up while I'm in there.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8437a23) 69.18% compared to head (7c06716) 69.18%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #26280   +/-   ##
=======================================
  Coverage   69.18%   69.18%           
=======================================
  Files        1946     1946           
  Lines       75969    75969           
  Branches     8469     8469           
=======================================
  Hits        52561    52561           
  Misses      21223    21223           
  Partials     2185     2185           
Flag Coverage Δ
hive 53.67% <ø> (ø)
javascript 56.52% <ø> (ø)
mysql 78.08% <ø> (ø)
postgres 78.18% <ø> (ø)
presto 53.63% <ø> (ø)
python 82.86% <ø> (ø)
sqlite 76.84% <ø> (ø)
unit 55.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rusackas rusackas merged commit 51172ca into master Dec 15, 2023
52 checks passed
@mistercrunch mistercrunch deleted the in-the-wild-cleanup branch March 26, 2024 18:06
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.0.0 labels Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 4.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants