chore: Add downloadAsImage types, change filter selector #26297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #26297 +/- ##
=======================================
Coverage 69.18% 69.18%
=======================================
Files 1945 1945
Lines 75968 75968
Branches 8467 8467
=======================================
Hits 52557 52557
Misses 21224 21224
Partials 2187 2187
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kgabryje
force-pushed
the
chore/download-as-image-cleanup
branch
from
c3be0eb
to
04bda5f
Compare
kgabryje
changed the title
john-bodley
added
the
review:checkpoint
|
/testenv up |
|
@rusackas Ephemeral environment spinning up at http://35.87.27.252:8080. Credentials are |
michael-s-molina
removed
the
review:checkpoint
eschutho
approved these changes
Dec 20, 2023
|
Ephemeral environment shutdown and build artifacts deleted. |
michael-s-molina
added
v3.1
michael-s-molina
pushed a commit
that referenced
this pull request
Dec 27, 2023
(cherry picked from commit 5e85f5c)
josedev-union
pushed a commit
to Ortege-xyz/studio
that referenced
this pull request
Jan 22, 2024
(cherry picked from commit 5e85f5c)
mistercrunch
added
🍒 3.1.0
🍒 3.1.1
🏷️ bot
sfirke
pushed a commit
to sfirke/superset
that referenced
this pull request
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR adds a dev dependency with types for
dom-to-imagepackage. Also filters outheader-controlsinstead of onlyant-dropdowntrigger before taking a screenshot.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
Use "Download as image" option on a chart in Explore, a chart in a dashboard and on the whole dashboard, verify that it works.
ADDITIONAL INFORMATION