Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sqlalchemy): import from correct path #26301

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

villebro
Copy link
Member

@villebro villebro commented Dec 18, 2023

SUMMARY

While doing some unrelated work I noticed that some SQLAlchemy exceptions have moved from sqlalchemy.orm.exc to sqlalchemy.exc as of 1.4, namely NoResultFound and MultipleResultsFound:

image image

See https://docs.sqlalchemy.org/en/20/core/exceptions.html for the docs.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link

codecov bot commented Dec 18, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (04f1c35) 69.18% compared to head (fa56178) 69.18%.

Files Patch % Lines
superset/commands/importers/v1/examples.py 0.00% 1 Missing ⚠️
superset/views/base_schemas.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #26301      +/-   ##
==========================================
- Coverage   69.18%   69.18%   -0.01%     
==========================================
  Files        1945     1945              
  Lines       75967    75966       -1     
  Branches     8466     8466              
==========================================
- Hits        52556    52555       -1     
  Misses      21224    21224              
  Partials     2187     2187              
Flag Coverage Δ
hive 53.67% <66.66%> (-0.01%) ⬇️
mysql 78.08% <66.66%> (-0.01%) ⬇️
postgres 78.18% <66.66%> (-0.01%) ⬇️
presto 53.62% <66.66%> (-0.01%) ⬇️
python 82.86% <66.66%> (-0.01%) ⬇️
sqlite 76.83% <66.66%> (-0.01%) ⬇️
unit 55.79% <66.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@villebro villebro merged commit 596f556 into apache:master Dec 18, 2023
36 checks passed
@villebro villebro deleted the villebro/orm-exc-move branch December 19, 2023 07:02
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.0.0 labels Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 4.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants